Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAINTAINERS.md format. #2376

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 5, 2023

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.

@dblock dblock requested a review from a team January 5, 2023 17:48
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have repo specific responsibilities in this document, should they be here or is there a project-wide practice for this elsewhere?

MAINTAINERS.md Show resolved Hide resolved
@dblock dblock requested a review from peternied January 5, 2023 19:14
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dblock !

@codecov-commenter
Copy link

Codecov Report

Merging #2376 (ac7d717) into main (67e4176) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2376      +/-   ##
============================================
- Coverage     61.09%   61.04%   -0.05%     
+ Complexity     3271     3266       -5     
============================================
  Files           260      260              
  Lines         18363    18363              
  Branches       3250     3250              
============================================
- Hits          11219    11210       -9     
- Misses         5559     5563       +4     
- Partials       1585     1590       +5     
Impacted Files Coverage Δ
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...ensearch/security/compliance/ComplianceConfig.java 82.63% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwperks cwperks merged commit 563df8f into opensearch-project:main Jan 5, 2023
@dblock dblock deleted the updated-maintainers branch January 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants