Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RestHelper and IndexTemplateCluster test for backport #1885: opendistro-1.12 #2013

Conversation

rutuja-amazon
Copy link
Contributor

@rutuja-amazon rutuja-amazon commented Aug 10, 2022

Fixes for RestHelper.java and IndexTemplateClusterPermissionsCheckTest.java for #1986

Description

Fixes backport of #1885

Issues Resolved

Backport PR #1885

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rutuja-amazon rutuja-amazon requested a review from a team August 10, 2022 11:43
@rutuja-amazon rutuja-amazon changed the title fix resthelper and indextemplatecluster test for backport #1885: opendistro-1.12 fix RestHelper and IndexTemplateCluster test for backport #1885: opendistro-1.12 Aug 10, 2022
@rutuja-amazon rutuja-amazon changed the title fix RestHelper and IndexTemplateCluster test for backport #1885: opendistro-1.12 Fixes RestHelper and IndexTemplateCluster test for backport #1885: opendistro-1.12 Aug 10, 2022
@peternied
Copy link
Member

After much consideration and discussion the branch that is being targeted opendistro-1.1* is unsupported, and this code is being used and maintained by a private fork. Rather than gate changes to a fork, it makes more sense for that repository to diverge in the areas its supporting but this repository are not supporting. This avoids having to wait on the security maintainers to review / approve / merge changes - doubly so when these changes cannot be validated by the CI systems in GitHub associated with them.

I am closing out this pull request and the other related pull requests, separately we will consider how we want to address these branches that are no longer supported, in other OpenSearch Project components the ODFE versions of the codebases were archived whereas this one was copied with all its issues.

@peternied peternied closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants