Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "backport cluster evaluation permissions #1885 to opendistro-1.11" #2009

Conversation

rutuja-amazon
Copy link
Contributor

@rutuja-amazon rutuja-amazon commented Aug 10, 2022

Reverts #1986

Description

Reverts backport of #1885 to opendistro-1.11 - this was causing unforeseen changes on the managed service end.

Issues Resolved

Backport PR #1885

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rutuja-amazon rutuja-amazon requested a review from a team August 10, 2022 01:49
@rutuja-amazon rutuja-amazon force-pushed the revert-1986-backport/backport-1964-to-opendistro-1.11 branch from fda4ef8 to 51b83b2 Compare August 10, 2022 01:52
@peternied
Copy link
Member

Why revert this whole change instead of fixing the build break?

@rutuja-amazon
Copy link
Contributor Author

rutuja-amazon commented Aug 10, 2022

@peternied There are two classes RestHelper and IndexTemplateClusterPermissionsCheckTest that have issues - RestHelper needed a lot of functionality to be added in the back-port and the import paths in this version are different than the later versions. This would need refactoring on classes like ClusterInfo, etc. which will require additional work. If we can revert the changes now - since this is urgently blocking MS changes, I can re-raise a new PR with required refactoring for backport post this version getting stabilised.

… to opendistro-1.11 (opensearch-project#1986)"

This reverts commit ec80578.

Signed-off-by: Rutuja Surve <[email protected]>
@rutuja-amazon rutuja-amazon force-pushed the revert-1986-backport/backport-1964-to-opendistro-1.11 branch from 51b83b2 to 25e6a70 Compare August 10, 2022 07:48
@rutuja-amazon
Copy link
Contributor Author

There is SSLHandshakeException causing CI failure.

@peternied
Copy link
Member

After much consideration and discussion the branch that is being targeted opendistro-1.1* is unsupported, and this code is being used and maintained by a private fork. Rather than gate changes to a fork, it makes more sense for that repository to diverge in the areas its supporting but this repository are not supporting. This avoids having to wait on the security maintainers to review / approve / merge changes - doubly so when these changes cannot be validated by the CI systems in GitHub associated with them.

I am closing out this pull request and the other related pull requests, seperately we will consider how we want to address these branches that are no longer supported, in other OpenSearch Project components the ODFE versions of the codebases were archived whereas this one was copied with all its issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants