Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved dco.yml to workflows folder #1469

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

davidlago
Copy link

Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

Github Issue # or road-map entry, if available:

Closes #1463

Description of changes:

Added DCO check to repository

Why these changes are required?

See opensearch-project/project-meta#17

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

No DCO checks on PR

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

N/A

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

N/A

Is it backport from main branch? (If yes, please add backport PR # and commits #)

No

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@davidlago davidlago requested a review from a team October 17, 2021 19:31
@davidlago davidlago mentioned this pull request Oct 17, 2021
2 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1469 (7b5ba45) into main (b033d64) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1469      +/-   ##
============================================
- Coverage     64.90%   64.88%   -0.02%     
+ Complexity     3232     3229       -3     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
- Hits          11251    11248       -3     
- Misses         4528     4531       +3     
  Partials       1556     1556              
Impacted Files Coverage Δ
...ecurity/configuration/ConfigurationRepository.java 73.07% <0.00%> (-2.20%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 60.86% <0.00%> (-1.45%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 68.08% <0.00%> (+4.25%) ⬆️
...ecurity/configuration/StaticResourceException.java 25.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b033d64...7b5ba45. Read the comment docs.

@hardik-k-shah hardik-k-shah merged commit 9bbecda into opensearch-project:main Oct 17, 2021
@davidlago davidlago deleted the adding-dco-check-2 branch October 17, 2021 22:49
@cliu123 cliu123 added the maintenance Project maintenance label Nov 8, 2021
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure DCO Workflow Check
5 participants