Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes branch filter on test workflow #930

Merged

Conversation

DarshitChanpura
Copy link
Member

Description

Updates unit and integration test workflow to run on all branches rather than just the main branch

Category

Maintenance

Why these changes are required?

To run test on all PRs

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura requested a review from a team March 28, 2022 18:52
cliu123
cliu123 previously approved these changes Mar 28, 2022
@cliu123
Copy link
Member

cliu123 commented Mar 28, 2022

ITs failed.

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Mar 28, 2022

yes...because it is unable to find the latest 1.3.1.0 image for security-plugin:
Run wget -O opensearch-security.zip https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/latest/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
--2022-03-28 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/latest/linux/x6[4](https://github.com/opensearch-project/security-dashboards-plugin/runs/5725831115?check_suite_focus=true#step:3:4)/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Resolving ci.opensearch.org (ci.opensearch.org)... [5](https://github.com/opensearch-project/security-dashboards-plugin/runs/5725831115?check_suite_focus=true#step:3:5)4.192.192.28, 54.192.192.13, 54.192.192.87, ...
Connecting to ci.opensearch.org (ci.opensearch.org)|54.192.192.28|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: /ci/dbc/distribution-build-opensearch/1.3.1/15[6](https://github.com/opensearch-project/security-dashboards-plugin/runs/5725831115?check_suite_focus=true#step:3:6)1/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip [following]
--2022-03-2[8](https://github.com/opensearch-project/security-dashboards-plugin/runs/5725831115?check_suite_focus=true#step:3:8) 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/1561/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden
2022-03-28 18:53:23 ERROR 403: Forbidden.

peternied
peternied previously approved these changes Mar 28, 2022
@peternied
Copy link
Member

In this change you also need to resolve the bad references in the integration test run for 1.3

@DarshitChanpura
Copy link
Member Author

In this change you also need to resolve the bad references in the integration test run for 1.3

Should I revert the wget commands in the ymls to use 1.3.0.0 instead of 1.3.1.0? Or is it something else that you are pointing to?

@peternied
Copy link
Member

This change is being merged onto 1.3 and from the error, the 1.3.1 build isn't resolving as its getting a 403. How are we planning on fixing this?

--2022-03-28 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/1561/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden

@peternied
Copy link
Member

This change is being merged onto 1.3 and from the error, the 1.3.1 build isn't resolving as its getting a 403. How are we planning on fixing this?

--2022-03-28 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/1561/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden

[Offline] We haven't yet added the security backend changes into the 1.3.1 manifest, after this has been done and a build has been created the URL will start to work.

@DarshitChanpura
Copy link
Member Author

This change is being merged onto 1.3 and from the error, the 1.3.1 build isn't resolving as its getting a 403. How are we planning on fixing this?

--2022-03-28 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/1561/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden

[Offline] We haven't yet added the security backend changes into the 1.3.1 manifest, after this has been done and a build has been created the URL will start to work.

Once this PR: opensearch-project/opensearch-build#1840 gets merged we can re-run the ITs for this branch.

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Mar 29, 2022

This change is being merged onto 1.3 and from the error, the 1.3.1 build isn't resolving as its getting a 403. How are we planning on fixing this?

--2022-03-28 18:53:22--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/1561/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.1.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden

[Offline] We haven't yet added the security backend changes into the 1.3.1 manifest, after this has been done and a build has been created the URL will start to work.

Once this PR: opensearch-project/opensearch-build#1840 gets merged we can re-run the ITs for this branch.

PR: #1840 has been merged and I have re-run IT job now but it is still unable to locate the 1.3.1.0 artifact.

@DarshitChanpura DarshitChanpura changed the title Removes test workflow branch filter Removes branch filter on test workflow Mar 29, 2022
@DarshitChanpura DarshitChanpura dismissed stale reviews from peternied and cliu123 via e2c6a25 March 29, 2022 19:38
@DarshitChanpura
Copy link
Member Author

@cliu123 @peternied can i get your review on this PR?

@peternied peternied merged commit f797354 into opensearch-project:1.3 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants