[Backport 2.x] Do not register tenancy app if disabled in yml #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Do not register tenancy app if disabled in yml Signed-off-by: Derek Ho <[email protected]> * Adds a test Signed-off-by: Derek Ho <[email protected]> * Revert type and export Signed-off-by: Derek Ho <[email protected]> * Use constants Signed-off-by: Derek Ho <[email protected]> * Remove extra license field Signed-off-by: Derek Ho <[email protected]> * Refactor with constants Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 0ed2cf2)
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
derek-ho
approved these changes
Jul 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2065 +/- ##
==========================================
+ Coverage 69.46% 71.17% +1.70%
==========================================
Files 96 96
Lines 2597 2598 +1
Branches 386 380 -6
==========================================
+ Hits 1804 1849 +45
+ Misses 699 649 -50
- Partials 94 100 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0ed2cf2 from #2057