Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses CVE-2024-4068 and updates yarn.lock #2039

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Jul 16, 2024

Description

Updates yarn.lock
Addresses CVE-2024-4068

Category

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. We are not using debug, it is a transitive dependency, so it shouldn't be added here. We already have a resolution for it.

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (2e53b3c) to head (3f10b7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2039   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      380      387    +7     
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yarn.lock Show resolved Hide resolved
Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura DarshitChanpura self-assigned this Jul 17, 2024
@derek-ho
Copy link
Collaborator

@DarshitChanpura can we update the title/description of this PR that we are addressing the braces CVE?

@DarshitChanpura
Copy link
Member Author

@derek-ho Anything blocking this PR from getting merged?

@DarshitChanpura DarshitChanpura changed the title Updates yarn.lock Addresses CVE-2024-4068 and updates yarn.lock Jul 17, 2024
@derek-ho
Copy link
Collaborator

@derek-ho Anything blocking this PR from getting merged?

Nope it looks good to me now

@cwperks cwperks merged commit 0592b68 into opensearch-project:main Jul 17, 2024
19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
* Updates yarn.lock

Signed-off-by: Darshit Chanpura <[email protected]>

* Forces braces to 3.0.3

Signed-off-by: Darshit Chanpura <[email protected]>

* Runs yarn

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 0592b68)
derek-ho pushed a commit that referenced this pull request Jul 18, 2024
* Updates yarn.lock

Signed-off-by: Darshit Chanpura <[email protected]>

* Forces braces to 3.0.3

Signed-off-by: Darshit Chanpura <[email protected]>

* Runs yarn

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 0592b68)

Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants