Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http proxy support for oidc #2024

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

Manuelraa
Copy link
Contributor

Description

Add http proxy support for oidc

Category

Enhancement

Why these changes are required?

Users of OpenSearch Dashboards in Companies which require use of http proxy struggle to implement OIDC.

What is the old behavior before changes and new behavior after changes?

ODIC http requests now support proxies.

Issues Resolved

Resolves: #911

Testing

Starting OpenSearch and OpenSearch Dashboards locally. Configure OIDC and set https_proxy variable. Then validate that requests are sent to proxy.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (0592b68) to head (d72eb5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2024   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      387      387           
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Jul 16, 2024

@Manuelraa Can you change the base branch of this PR to main? After merge into main it can be backported to the 2.x release branch through a label.

@cwperks
Copy link
Member

cwperks commented Jul 16, 2024

The changes in this PR look ok to me. Wdyt about filing an issue about adding a functional test that covers a setup with an OIDC IdP behind a proxy?

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @cwperks comment. Let's rebase this main and then backport it using backport 2.x label.

@Manuelraa
Copy link
Contributor Author

The changes in this PR look ok to me. Wdyt about filing an issue about adding a functional test that covers a setup with an OIDC IdP behind a proxy?

Sure #2043 created

@Manuelraa Manuelraa changed the base branch from 2.x to main July 18, 2024 08:14
@Manuelraa
Copy link
Contributor Author

+1 to @cwperks comment. Let's rebase this main and then backport it using backport 2.x label.

Rebased to main. Could you add the required label please?

@cwperks cwperks added the backport 2.x backport to 2.x branch label Jul 18, 2024
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @Manuelraa

@cwperks cwperks merged commit fe847af into opensearch-project:main Jul 18, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2024
* feat: http proxy support for oidc

Resolves: #911
Signed-off-by: manuelraa <[email protected]>

* chore: reduce code duplication for agent configuration

Signed-off-by: Manuelraa <[email protected]>

---------

Signed-off-by: manuelraa <[email protected]>
Signed-off-by: Manuelraa <[email protected]>
(cherry picked from commit fe847af)
derek-ho pushed a commit that referenced this pull request Jul 18, 2024
* feat: http proxy support for oidc

Resolves: #911
Signed-off-by: manuelraa <[email protected]>

* chore: reduce code duplication for agent configuration

Signed-off-by: Manuelraa <[email protected]>

---------

Signed-off-by: manuelraa <[email protected]>
Signed-off-by: Manuelraa <[email protected]>
(cherry picked from commit fe847af)

Co-authored-by: Manuelraa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support httpsProxy in OpenSearch Dashboards for OIDC support
3 participants