-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug of capabilities request not supporting carrying authinfo #2014
Fix the bug of capabilities request not supporting carrying authinfo #2014
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2014 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 387 387
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Blocked on: #2009 to fix the main CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yubonluo Thank you for the PR. Would you also add a test to confirm the behavior?
Signed-off-by: yubonluo <[email protected]>
…rds-plugin into capabilities-support-authinfo
826cf0e
to
6de5625
Compare
@DarshitChanpura Sure, the unit test has been added. |
@derek-ho @RyanL1997 @DarshitChanpura Cloud you please help me to review and merge this pr? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @yubonluo I am not familiar with this API, can you provide some more information on how it is used/how to hit it on my local so I can try to replicate and understand what use case this is solving? Is this related? https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/server/capabilities/routes/resolve_capabilities.ts#L40
@derek-ho Yes, this is related. The capabilities service provide two methods (https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/server/capabilities/capabilities_service.ts).
|
50f7d2f
to
3bc290f
Compare
Signed-off-by: yubonluo <[email protected]>
3bc290f
to
c78e1af
Compare
Signed-off-by: yubonluo <[email protected]>
@derek-ho Cloud you help me merge this pr? Thanks~ |
…2014) * capabilities api support authinfo Signed-off-by: yubonluo <[email protected]> * optimize the annotation Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 293490d)
…2014) (#2017) * capabilities api support authinfo Signed-off-by: yubonluo <[email protected]> * optimize the annotation Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 293490d) Co-authored-by: yuboluo <[email protected]>
Description
Fix the issue of capabilities API not supporting carrying authinfo。
Category
Bug fix
Why these changes are required?
When user call
core.capabilities.registerSwitcher
to store certain state which is about authinfo, the request need carry the auth information.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.