-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Always show security screen and shows error page when trying to access forbidden data-source (#1964) #1984
Merged
derek-ho
merged 6 commits into
opensearch-project:2.x
from
DarshitChanpura:backport-1964-to-2.x
Jun 4, 2024
Merged
[Backport 2.x] Always show security screen and shows error page when trying to access forbidden data-source (#1964) #1984
derek-ho
merged 6 commits into
opensearch-project:2.x
from
DarshitChanpura:backport-1964-to-2.x
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s forbidden data-source (opensearch-project#1964) Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
cliu123,
cwperks,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
June 3, 2024 16:24
Signed-off-by: Darshit Chanpura <[email protected]>
RyanL1997
approved these changes
Jun 4, 2024
derek-ho
reviewed
Jun 4, 2024
derek-ho
reviewed
Jun 4, 2024
public/apps/configuration/panels/test/__snapshots__/service-account-list.test.tsx.snap
Outdated
Show resolved
Hide resolved
derek-ho
reviewed
Jun 4, 2024
public/apps/configuration/panels/test/service-account-list.test.tsx
Outdated
Show resolved
Hide resolved
derek-ho
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some files were pulled in in the merge conflict
We should delete service accounts on main if we have no plans to move forward with it, to prevent these pesky backport failures |
Signed-off-by: Darshit Chanpura <[email protected]>
Argh, good catch. Removed those files. |
derek-ho
approved these changes
Jun 4, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backports #1964
Manual backport is required because:
Check List
- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.