Fix oidc cypress test and remove doc link #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
cwperks
reviewed
Apr 30, 2024
DarshitChanpura
approved these changes
Apr 30, 2024
stephen-crawford
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 23604d1)
derek-ho
added a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 23604d1) Co-authored-by: Derek Ho <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 23604d1)
derek-ho
added a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 23604d1) Co-authored-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes OIDC cypress tests after upstream changes on devtools page.
Category
Maintenance
Why these changes are required?
Upstream changes in OSD introduced new components, we need to specify which component in our test to avoid upstream changes from breaking our tests
What is the old behavior before changes and new behavior after changes?
OIDC tests will now pass
Issues Resolved
Fix: #1922
Fix: #1850
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.