Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jose from 4.11.2 to 5.2.4 #1902

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 24, 2024

Description

Bump jose from 4.11.2 to 5.2.4

Addresses CVE-2024-28176

Category

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Apr 24, 2024

Here's the release notes from v5: https://github.com/panva/jose/releases/tag/v5.0.0

If v5 causes issues then this can also be upgraded to 4.15.5: https://www.npmjs.com/package/jose/v/4.15.5

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks shall we wait until the CVE is actually published prior to merge?

@cwperks
Copy link
Member Author

cwperks commented Apr 25, 2024

@cwperks shall we wait until the CVE is actually published prior to merge?

It can be merged now. 4.11.2 is from a year ago and there have been many versions published since.

@DarshitChanpura DarshitChanpura merged commit f4b4c83 into opensearch-project:main Apr 25, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit f4b4c83)
DarshitChanpura pushed a commit that referenced this pull request Apr 25, 2024
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit f4b4c83)

Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants