Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some state issues and try to use electron browser #1894

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Apr 16, 2024

Description

Changes some code in the Roles tab and tries to find ways around flaky cypress test e2e multi-datasources enabled. Runs are consistently working on local, but fails due to cypress crashing on github runners.

Category

Maintenance

Why these changes are required?

Fix #1885

What is the old behavior before changes and new behavior after changes?

Cypress tests consistently crash and fail the multi datasources test, hopefully become more stable/passing afterwards.

Issues Resolved

Fix #1885

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@@ -63,7 +63,7 @@ runs:
if: ${{ runner.os == 'Linux' }}
run: |
cd ./OpenSearch-Dashboards
nohup yarn start --no-base-path --no-watch | tee dashboard.log &
nohup yarn start --no-base-path --no-watch --csp.warnLegacyBrowsers=false | tee dashboard.log &
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove popup

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.22%. Comparing base (5f0f592) to head (29d29ca).

❗ Current head 29d29ca differs from pull request most recent head 8865a8b. Consider uploading reports for the commit 8865a8b to get more accurate results

Files Patch % Lines
...ration/panels/role-edit/index-permission-panel.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           feature/supporting-multiple-datasources    #1894      +/-   ##
===========================================================================
- Coverage                                    69.23%   69.22%   -0.02%     
===========================================================================
  Files                                           96       96              
  Lines                                         2477     2479       +2     
  Branches                                       338      338              
===========================================================================
+ Hits                                          1715     1716       +1     
  Misses                                         683      683              
- Partials                                        79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@derek-ho
Copy link
Collaborator Author

Closing in favor of #1898

@derek-ho derek-ho closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant