-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some state issues and try to use electron browser #1894
Fix some state issues and try to use electron browser #1894
Conversation
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@@ -63,7 +63,7 @@ runs: | |||
if: ${{ runner.os == 'Linux' }} | |||
run: | | |||
cd ./OpenSearch-Dashboards | |||
nohup yarn start --no-base-path --no-watch | tee dashboard.log & | |||
nohup yarn start --no-base-path --no-watch --csp.warnLegacyBrowsers=false | tee dashboard.log & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove popup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1894 +/- ##
===========================================================================
- Coverage 69.23% 69.22% -0.02%
===========================================================================
Files 96 96
Lines 2477 2479 +2
Branches 338 338
===========================================================================
+ Hits 1715 1716 +1
Misses 683 683
- Partials 79 80 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Closing in favor of #1898 |
Description
Changes some code in the Roles tab and tries to find ways around flaky cypress test e2e multi-datasources enabled. Runs are consistently working on local, but fails due to cypress crashing on github runners.
Category
Maintenance
Why these changes are required?
Fix #1885
What is the old behavior before changes and new behavior after changes?
Cypress tests consistently crash and fail the multi datasources test, hopefully become more stable/passing afterwards.
Issues Resolved
Fix #1885
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.