-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster info to toasts, adds cluster info to URL #1877
Add cluster info to toasts, adds cluster info to URL #1877
Conversation
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1877 +/- ##
===========================================================================
- Coverage 68.90% 68.35% -0.56%
===========================================================================
Files 96 96
Lines 2460 2474 +14
Branches 335 334 -1
===========================================================================
- Hits 1695 1691 -4
- Misses 686 703 +17
- Partials 79 80 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derek-ho thanks for adding this. Will the tests suffice this? One more question, have tested the state after page refresh?
public/apps/configuration/panels/permission-list/permission-list.tsx
Outdated
Show resolved
Hide resolved
Blocked on: opensearch-project/OpenSearch-Dashboards#6367 |
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is still in progress based on bunch of log statements and linter errors. Should this marked as draft @derek-ho ?
Signed-off-by: Derek Ho <[email protected]>
Just pulled in changes from core, letting CI finish, but it should be ready for review now. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
public/apps/configuration/panels/internal-user-edit/internal-user-edit.tsx
Show resolved
Hide resolved
public/apps/configuration/panels/audit-logging/test/__snapshots__/audit-logging.test.tsx.snap
Show resolved
Hide resolved
… from URL Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
…opensearch-project/security-dashboards-plugin into ui-fixes Signed-off-by: Derek Ho <[email protected]>
…back to 2.4 Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, waiting for CI to be green before approving. Nice work @derek-ho !
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
CI failures seems flaky and unrelated to this change. These will be addressed in follow-ups. Merging this now. |
9f350b0
into
opensearch-project:feature/supporting-multiple-datasources
Description
This PR adds cluster info to toasts for permissions, roles, and users. It also adds the data source id to the url and reads from the datasourceid if available from the url. This should help with page refreshes/auto logouts, and sharing links.
Category
Enhancement
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Toasts did not have cluster info, datasource was not saved in URL
Issues Resolved
Fix: #1858
Fix: #1860
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.