Adds SSL test support, compatibility test support #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1856 +/- ##
===========================================================================
- Coverage 68.22% 68.20% -0.02%
===========================================================================
Files 96 96
Lines 2439 2441 +2
Branches 331 331
===========================================================================
+ Hits 1664 1665 +1
- Misses 696 697 +1
Partials 79 79 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
changed the title
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997 and
stephen-crawford
as code owners
derek-ho
commented
Mar 27, 2024
| @@ -98,7 +98,7 @@ describe('Multi-datasources enabled', () => { | |||
| cy.get('[data-test-subj="dataSourceSelectableContextMenuHeaderLink"]').contains('9202'); | |||
| }); | |||
|
|
|||
| it('Checks Users Tab', () => { | |||
| it.skip('Checks Users Tab', () => { | |||
There was a problem hiding this comment.
Skipping the flaky test, will re-enable when reading from url to avoid unnecessary component clicks. #1858
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
DarshitChanpura
approved these changes
Mar 28, 2024
DarshitChanpura
merged commit 9bceddf
into
opensearch-project:feature/supporting-multiple-datasources
33 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to @cwperks' heroic efforts, we are able to re-enable https on test clusters, and we can cleanup a lot of testing infrastructure to simply add the port, instead of re-writing entire files to disable https.
This PR also adds compatibility test support for linux and windows down to 2.4 (windows released in 2.4), and verifies that the API calls we are making are working as expected on clusters of different versions.
Category
Enhancement
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
Fix #1853
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.