Use a common constant to specify the version for log type mappings #708 #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowg-amazon
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
============================================
+ Coverage 24.73% 24.77% +0.03%
- Complexity 1021 1022 +1
============================================
Files 275 275
Lines 12662 12668 +6
Branches 1389 1389
============================================
+ Hits 3132 3138 +6
Misses 9264 9264
Partials 266 266 ☔ View full report in Codecov by Sentry. |
eirsep
reviewed
Nov 30, 2023
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
sbcd90
approved these changes
Dec 8, 2023
goyamegh
approved these changes
Dec 8, 2023
AWSHurneyt
approved these changes
Dec 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
… (#734) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
… (#734) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
… (#734) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923)
jowg-amazon
added a commit
that referenced
this pull request
Dec 8, 2023
… (#734) (#777) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923) Co-authored-by: Joanne Wang <[email protected]>
jowg-amazon
added a commit
that referenced
this pull request
Dec 8, 2023
… (#734) (#776) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923) Co-authored-by: Joanne Wang <[email protected]>
jowg-amazon
added a commit
that referenced
this pull request
Dec 8, 2023
… (#734) (#778) * json parser Signed-off-by: Joanne Wang <[email protected]> * update gradle json dependency Signed-off-by: Joanne Wang <[email protected]> * use xcontenthelper to parse json file Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7066923) Co-authored-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the
log_type_mapping_versioninLogTypeService.javato the same schema version values used inlog_type_config_mapping.jsonIssues Resolved
#708
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.