-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#709 Return empty response for empty mappings and no applied aliases #724
#709 Return empty response for empty mappings and no applied aliases #724
Conversation
plz add rest tests for both the scenarios |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
============================================
- Coverage 24.81% 24.74% -0.08%
Complexity 1021 1021
============================================
Files 275 275
Lines 12670 12663 -7
Branches 1390 1389 -1
============================================
- Hits 3144 3133 -11
- Misses 9258 9264 +6
+ Partials 268 266 -2 ☔ View full report in Codecov by Sentry. |
fix dco |
…o applied aliases Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
6ad9519
to
d8bcecb
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-724-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7bd934b79f7c3a911229fa63e157116ec5ca9
# Push it to GitHub
git push --set-upstream origin backport/backport-724-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-724-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7bd934b79f7c3a911229fa63e157116ec5ca9
# Push it to GitHub
git push --set-upstream origin backport/backport-724-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-724-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7bd934b79f7c3a911229fa63e157116ec5ca9
# Push it to GitHub
git push --set-upstream origin backport/backport-724-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-724-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7bd934b79f7c3a911229fa63e157116ec5ca9
# Push it to GitHub
git push --set-upstream origin backport/backport-724-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7 Then, create a pull request where the |
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9)
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9)
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9)
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9)
…o applied aliases (opensearch-project#724) * opensearch-project#709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9)
…724) (#748) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]>
…724) (#748) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]> (cherry picked from commit 4f68164)
…724) (#748) (#758) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]> (cherry picked from commit 4f68164) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
…724) (#750) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]>
…724) (#747) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]>
…724) (#749) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <[email protected]>
#757) * #709 Return empty response for empty mappings and no applied aliases (#724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <[email protected]> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <[email protected]> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit c0f7bd9) * #709 Fix merge conflicts while backporting Signed-off-by: Megha Goyal <[email protected]> * #709 Fix merge conflicts while backporting Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]>
Description
Returns an empty response instead of exception in case of:
Issues Resolved
#709
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.