-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] rebase to support latest core snapshot #510
[Refactor] rebase to support latest core snapshot #510
Conversation
This commit refactors the codebase to comply with latest breaking changes on the core repository. Signed-off-by: Nicholas Walter Knize <[email protected]>
/cc @sbcd90 @getsaurabh02 |
I'm not sure spotlessApply is running like I'd expect. Maybe we should check w/ @peternied if the security team was able to get it working w/ the security repo. |
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
============================================
- Coverage 28.20% 28.17% -0.04%
+ Complexity 941 939 -2
============================================
Files 236 236
Lines 9864 9864
Branches 1118 1118
============================================
- Hits 2782 2779 -3
- Misses 6841 6842 +1
- Partials 241 243 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @nknize .
@nknize Hmm, are you expecting to have the formatter run when running In the security repo we don't have any task dependency to it in our security plugin, instead we have separate code hygiene workflows that trigger the task. Confirmed this was the case for the security plugin by using gradle-task-tree
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security tests are failing since docker image are not up to date.
hi @peternied , will look into it. |
…#510) This commit refactors the codebase to comply with latest breaking changes on the core repository. Signed-off-by: Nicholas Walter Knize <[email protected]>
This PR refactors the codebase to comply with latest breaking changes on the core repository. It also updates gradle to the same version as core (currently 8.2.1) and adds initial support for spotless plugin.