Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Handle monitor or monitor index not found during detector deletion #398

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6271399 from #384

…384)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 6271399)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team April 12, 2023 20:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #398 (eb6f6a4) into 2.x (6974b33) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x     #398   +/-   ##
=========================================
  Coverage     35.62%   35.63%           
- Complexity      881      885    +4     
=========================================
  Files           186      186           
  Lines          7285     7297   +12     
  Branches        880      885    +5     
=========================================
+ Hits           2595     2600    +5     
- Misses         4451     4460    +9     
+ Partials        239      237    -2     
Impacted Files Coverage Δ
...ytics/transport/TransportDeleteDetectorAction.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit 2e9dbbd into 2.x Apr 12, 2023
@github-actions github-actions bot deleted the backport/backport-384-to-2.x branch April 12, 2023 20:39
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics that referenced this pull request Jun 9, 2023
…pensearch-project#384) (opensearch-project#398)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 6271399)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt added a commit that referenced this pull request Jun 9, 2023
* handle index not exists for detector search and delete (#396) (#397)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e50c70a)

Co-authored-by: Surya Sashank Nistala <[email protected]>

* Handle monitor or monitor index not exists during detector deletion (#384) (#398)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 6271399)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants