-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test update detector with aggregation rules #1423
Merged
Merged
+205
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
December 16, 2024 05:15
eirsep
force-pushed
the
update_detector
branch
from
December 17, 2024 02:05
e333749
to
dd77d27
Compare
…rules Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
force-pushed
the
update_detector
branch
from
December 17, 2024 02:11
dd77d27
to
454e572
Compare
sbcd90
approved these changes
Dec 17, 2024
riysaxen-amzn
approved these changes
Dec 17, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.13
# Create a new branch
git switch --create backport-1423-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a4176bb532f9add63091ba5683a038a817600a1
# Push it to GitHub
git push --set-upstream origin backport-1423-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.13 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 8a4176b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 17, 2024
eirsep
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rules (#1423) (#1430) (cherry picked from commit 8a4176b) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
added
backport 2.x
and removed
backport 2.x
backport 2.13
backport 2.14
backport 2.15
backport 2.16
backport 2.17
labels
Dec 18, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.x
# Create a new branch
git switch --create backport-1423-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a4176bb532f9add63091ba5683a038a817600a1
# Push it to GitHub
git push --set-upstream origin backport-1423-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.x Then, create a pull request where the |
sbcd90
pushed a commit
that referenced
this pull request
Dec 18, 2024
…rules (#1423) (#1428) (cherry picked from commit 8a4176b) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Dec 18, 2024
…rules (#1423) (#1426) (cherry picked from commit 8a4176b) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since detectors with sigme aggregation rules create a single match_all doc level monitor to perform chained findings, we cannot use query_id of the doc level monitor to perform trigger condition where alerts are created on rule matches.
We add the rule id to tag so that we can create doc level trigger condition to match something like `
_(query[tag=cloudtrail]) && (query[tag=agg_rule_id1] || query [tag=agg_rule_id2])
instead of doing (query[tag=cloudtrail]) && (query[id=agg_rule_id1] || query [id=agg_rule_id2])
since query id of chained findings doc level monitor cannot associate to multiple agg rules that it will alert for.