Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.18] Add validation for threat intel source config #1409

Merged
merged 1 commit into from
Oct 30, 2024

Add validation for threat intel source config (#1393)

b3d1024
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.18] Add validation for threat intel source config #1409

Add validation for threat intel source config (#1393)
b3d1024
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

69.09% (+0.09%) compared to 2257af0

View this Pull Request on Codecov

69.09% (+0.09%) compared to 2257af0

Details

Codecov Report

Attention: Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.

Project coverage is 69.09%. Comparing base (2257af0) to head (b3d1024).

Files with missing lines Patch % Lines
...s/threatIntel/common/SourceConfigDtoValidator.java 29.72% 11 Missing and 15 partials ⚠️
...analytics/threatIntel/model/SATIFSourceConfig.java 81.81% 1 Missing and 1 partial ⚠️
...lytics/threatIntel/model/SATIFSourceConfigDto.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.18    #1409      +/-   ##
============================================
+ Coverage     69.00%   69.09%   +0.09%     
- Complexity     3605     3620      +15     
============================================
  Files           405      405              
  Lines         20119    20150      +31     
  Branches       2045     2059      +14     
============================================
+ Hits          13883    13923      +40     
+ Misses         5213     5201      -12     
- Partials       1023     1026       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov