Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Add validation for threat intel source config #1408

Merged
merged 1 commit into from
Oct 31, 2024

Add validation for threat intel source config (#1393)

0c1bbd9
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.17] Add validation for threat intel source config #1408

Add validation for threat intel source config (#1393)
0c1bbd9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 30, 2024 in 0s

69.07% (-0.01%) compared to 7196ba8

View this Pull Request on Codecov

69.07% (-0.01%) compared to 7196ba8

Details

Codecov Report

Attention: Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.

Project coverage is 69.07%. Comparing base (7196ba8) to head (0c1bbd9).

Files with missing lines Patch % Lines
...s/threatIntel/common/SourceConfigDtoValidator.java 29.72% 11 Missing and 15 partials ⚠️
...analytics/threatIntel/model/SATIFSourceConfig.java 81.81% 1 Missing and 1 partial ⚠️
...lytics/threatIntel/model/SATIFSourceConfigDto.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.17    #1408      +/-   ##
============================================
- Coverage     69.07%   69.07%   -0.01%     
- Complexity     3603     3615      +12     
============================================
  Files           404      404              
  Lines         20127    20158      +31     
  Branches       2049     2063      +14     
============================================
+ Hits          13903    13924      +21     
- Misses         5198     5202       +4     
- Partials       1026     1032       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov