Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update min number of replicas to 0 #1364

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Oct 21, 2024

Description

update min number of replicas to 0.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

false,
true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep them as two separate commits?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok reverted this settings change.

@sbcd90 sbcd90 changed the title update min number of replicas to 0 and enable dedicated query indices to true update min number of replicas to 0 Oct 21, 2024
@@ -12,7 +12,7 @@

public class SecurityAnalyticsSettings {
public static final String CORRELATION_INDEX = "index.correlation";
public static final int minSystemIndexReplicas = 1;
public static final int minSystemIndexReplicas = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for single node cluster scenario?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@sbcd90 sbcd90 merged commit b185440 into opensearch-project:main Oct 21, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit b185440)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.15
# Create a new branch
git switch --create backport-1364-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b185440c63e091a769177a5e91e0f8dc2704d89a
# Push it to GitHub
git push --set-upstream origin backport-1364-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport-1364-to-2.15.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.17
# Create a new branch
git switch --create backport-1364-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b185440c63e091a769177a5e91e0f8dc2704d89a
# Push it to GitHub
git push --set-upstream origin backport-1364-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport-1364-to-2.17.

sbcd90 pushed a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit b185440)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90 added a commit to sbcd90/security-analytics that referenced this pull request Oct 22, 2024
@sbcd90 sbcd90 mentioned this pull request Oct 22, 2024
5 tasks
sbcd90 added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants