Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to add start_time and end_time filters to GetAlertsRequest #1039

Merged
merged 1 commit into from
May 22, 2024

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented May 21, 2024

Description

changes to add start_time and end_time filters to GetAlertsRequest

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link this issue to the PR -> #797

@sbcd90 sbcd90 merged commit 20905ce into opensearch-project:main May 22, 2024
13 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 22, 2024
…1039)

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 20905ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.11
# Create a new branch
git switch --create backport-1039-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20905ced42a52bf4ebc03275cf2f8d81f9421663
# Push it to GitHub
git push --set-upstream origin backport-1039-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-1039-to-2.11.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.12
# Create a new branch
git switch --create backport-1039-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20905ced42a52bf4ebc03275cf2f8d81f9421663
# Push it to GitHub
git push --set-upstream origin backport-1039-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-1039-to-2.12.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.13
# Create a new branch
git switch --create backport-1039-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20905ced42a52bf4ebc03275cf2f8d81f9421663
# Push it to GitHub
git push --set-upstream origin backport-1039-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport-1039-to-2.13.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.14
# Create a new branch
git switch --create backport-1039-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20905ced42a52bf4ebc03275cf2f8d81f9421663
# Push it to GitHub
git push --set-upstream origin backport-1039-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport-1039-to-2.14.

AWSHurneyt pushed a commit to AWSHurneyt/security-analytics that referenced this pull request Jun 4, 2024
sbcd90 pushed a commit that referenced this pull request Jun 12, 2024
…1039)

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 20905ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90 pushed a commit to sbcd90/security-analytics that referenced this pull request Jun 12, 2024
…pensearch-project#1039)

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 20905ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ignore flaky tests

Signed-off-by: Subhobrata Dey <[email protected]>
amsiglan pushed a commit that referenced this pull request Jun 12, 2024
…1039) (#1074)

(cherry picked from commit 20905ce)


ignore flaky tests

Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
toepkerd pushed a commit to toepkerd/security-analytics that referenced this pull request Jul 25, 2024
AWSHurneyt pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants