-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #984
Updated dependencies #984
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 31.61% 31.61%
=======================================
Files 159 159
Lines 5304 5304
Branches 993 993
=======================================
Hits 1677 1677
Misses 3436 3436
Partials 191 191 ☔ View full report in Codecov by Sentry. |
Fixed the failing test in PR #983 |
* updated dependencies Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated husky config Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted config Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix postinstall for husky Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit a94a511) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* updated dependencies Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated husky config Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted config Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix postinstall for husky Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit a94a511) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.12
# Create a new branch
git switch --create backport-984-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a94a511f04f7259ef501f7eefb84e8864ff9134d
# Push it to GitHub
git push --set-upstream origin backport-984-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.12 Then, create a pull request where the |
* updated dependencies * updated husky config * removed unwanted config * fix postinstall for husky --------- (cherry picked from commit a94a511) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* updated dependencies * updated husky config * removed unwanted config * fix postinstall for husky --------- (cherry picked from commit a94a511) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This change makes |
I can't build this commit with
So I have to patch diff --git a/package.json b/package.json
index 9d19dd5..53e3dc3 100644
--- a/package.json
+++ b/package.json
@@ -25,7 +25,7 @@
"test:jest:update-snapshots": "yarn run test:jest -u",
"build": "yarn plugin-helpers build",
"postbuild": "echo Renaming build artifact to [$npm_package_config_zip_name-$npm_package_version.zip] && mv build/$npm_package_config_id*.zip build/$npm_package_config_zip_name-$npm_package_version.zip",
- "postinstall": "husky install"
+ "postinstall": "cd ../../../ && husky install"
},
"resolutions": {
"@types/react": "^16.9.8", |
Also I have to bump I have created a PR that solves my build issue. |
Description
Updated dependencies to align with other plugin repos
Issues Resolved
#847
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.