Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #984

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Apr 2, 2024

Description

Updated dependencies to align with other plugin repos

Issues Resolved

#847

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

amsiglan added 3 commits April 1, 2024 18:43
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.61%. Comparing base (5c43a1d) to head (637e25b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   31.61%   31.61%           
=======================================
  Files         159      159           
  Lines        5304     5304           
  Branches      993      993           
=======================================
  Hits         1677     1677           
  Misses       3436     3436           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amsiglan
Copy link
Collaborator Author

amsiglan commented Apr 3, 2024

Fixed the failing test in PR #983

@amsiglan amsiglan merged commit a94a511 into opensearch-project:main Apr 3, 2024
8 of 10 checks passed
@amsiglan amsiglan added backport 2.x backport 2.13 Triggers backport to 2.13 branch backport 2.12 labels Apr 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 3, 2024
* updated dependencies

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated husky config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed unwanted config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fix postinstall for husky

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a94a511)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 3, 2024
* updated dependencies

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated husky config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed unwanted config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fix postinstall for husky

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a94a511)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.12
# Create a new branch
git switch --create backport-984-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a94a511f04f7259ef501f7eefb84e8864ff9134d
# Push it to GitHub
git push --set-upstream origin backport-984-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-984-to-2.12.

amsiglan pushed a commit that referenced this pull request Apr 3, 2024
* updated dependencies



* updated husky config



* removed unwanted config



* fix postinstall for husky



---------


(cherry picked from commit a94a511)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Apr 3, 2024
* updated dependencies



* updated husky config



* removed unwanted config



* fix postinstall for husky



---------


(cherry picked from commit a94a511)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AMoo-Miki
Copy link
Contributor

This change makes husky a dependency as it is used in postinstall. I don't believe the intention of this change was making husky a requirement for building release packages.

@nikAizuddin
Copy link

I can't build this commit with yarn build. I got the following error:

husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)

So I have to patch package.json with:

diff --git a/package.json b/package.json
index 9d19dd5..53e3dc3 100644
--- a/package.json
+++ b/package.json
@@ -25,7 +25,7 @@
     "test:jest:update-snapshots": "yarn run test:jest -u",
     "build": "yarn plugin-helpers build",
     "postbuild": "echo Renaming build artifact to [$npm_package_config_zip_name-$npm_package_version.zip] && mv build/$npm_package_config_id*.zip build/$npm_package_config_zip_name-$npm_package_version.zip",
-    "postinstall": "husky install"
+    "postinstall": "cd ../../../ && husky install"
   },
   "resolutions": {
     "@types/react": "^16.9.8",

@nikAizuddin
Copy link

Also I have to bump lint-staged package to ^13.1.0 because I'm having issues with lint-staged ^10.2.0 (if I remember correctly, it says I'm not in a .git directory whenever I use git commit).

I have created a PR that solves my build issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants