-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tsconfig and helper config #882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
February 13, 2024 21:52
AWSHurneyt
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approving assuming tests pass.
praveensameneni
approved these changes
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 157 157
Lines 5229 5229
Branches 925 925
=======================================
Hits 1623 1623
Misses 3419 3419
Partials 187 187 ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
Feb 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7b2a6f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7b2a6f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit 7b2a6f6) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit 7b2a6f6) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added a new config.ts file at the top level and it needs to be included in the compilation
Issues Resolved
#751
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.