Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig and helper config #882

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

amsiglan
Copy link
Collaborator

Description

We added a new config.ts file at the top level and it needs to be included in the compilation

Issues Resolved

#751

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving assuming tests pass.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e57820) 31.03% compared to head (a0ff12c) 31.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   31.03%   31.03%           
=======================================
  Files         157      157           
  Lines        5229     5229           
  Branches      925      925           
=======================================
  Hits         1623     1623           
  Misses       3419     3419           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amsiglan amsiglan merged commit 7b2a6f6 into opensearch-project:main Feb 13, 2024
11 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 13, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 7b2a6f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 13, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 7b2a6f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 7b2a6f6)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 7b2a6f6)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants