-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for mappings view API call during create detector #862
Add check for mappings view API call during create detector #862
Conversation
…detector Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 31.03% 31.02% -0.02%
==========================================
Files 151 151
Lines 5111 5116 +5
Branches 948 897 -51
==========================================
+ Hits 1586 1587 +1
- Misses 3335 3339 +4
Partials 190 190 ☔ View full report in Codecov by Sentry. |
…detector (#862) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0b9016d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…detector (#862) (#868) (cherry picked from commit 0b9016d) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-862-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b9016d8efc47e75cb9fe3291d0974cfe0c864eb
# Push it to GitHub
git push --set-upstream origin backport-862-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 Then, create a pull request where the |
Description
Currently the field mapping configuration component does a blanket check on changes made to the detector and tries to fetch the updated mappings for any change made to the detector.
This PR ensures we only check for relevant changes like the data source, log type or detection rules.
Issues Resolved
#861
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.