Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlations page improvements #855

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Jan 9, 2024

Description

Improvements to UI on the Correlations page

Issues Resolved

#828

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7837a99) 31.03% compared to head (5bc0c21) 31.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
+ Coverage   31.03%   31.05%   +0.02%     
==========================================
  Files         151      151              
  Lines        5111     5129      +18     
  Branches      948      903      -45     
==========================================
+ Hits         1586     1593       +7     
- Misses       3335     3346      +11     
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the windows cypress tests are failing, and they're known to have timeout issues. Rerunning those tests, and approving.

@amsiglan amsiglan merged commit cebf9cd into opensearch-project:main Feb 6, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2024
* ux improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated text styles

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit cebf9cd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Feb 6, 2024
* ux improvements



* updated text styles



---------


(cherry picked from commit cebf9cd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants