-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed update payload for correlation rule #838
Fixed update payload for correlation rule #838
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 31.01% 31.01% -0.01%
==========================================
Files 151 151
Lines 5101 5108 +7
Branches 890 946 +56
==========================================
+ Hits 1582 1584 +2
- Misses 3329 3334 +5
Partials 190 190 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Approving assuming the tests pass.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-838-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 368adf79568cd8de6884bab5fb5adeee81223152
# Push it to GitHub
git push --set-upstream origin backport-838-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.x Then, create a pull request where the |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <[email protected]> * improved validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * check for null values Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <[email protected]> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <[email protected]> * add already mapped log index fields to list of options (#845) Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <[email protected]> * improved validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * check for null values Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <[email protected]> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Description
If the query or field properties of correlation rule data source are empty, they should be null or not exist in the payload for the correlation rule to work correctly after update.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.