Make notifications optional #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
AWSHurneyt
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 31.17% 31.20% +0.03%
==========================================
Files 151 151
Lines 5008 5002 -6
Branches 910 908 -2
==========================================
Hits 1561 1561
+ Misses 3257 3252 -5
+ Partials 190 189 -1 |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep notification optional in create detector to block user from creating the detector. This is for the case when Notifications plugin is not installed in the frontend.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.