Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate import for EuiSpacer #538

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

Removed duplicate import for EuiSpacer

Issues Resolved

Fixes jest tests

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amsiglan amsiglan requested a review from a team April 19, 2023 13:46
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan force-pushed the remove-duplicate-import branch from 1031f28 to f73dc25 Compare April 19, 2023 13:50
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #538 (884cab4) into main (b7efb33) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   35.59%   35.53%   -0.07%     
==========================================
  Files         121      121              
  Lines        3444     3487      +43     
  Branches      602      609       +7     
==========================================
+ Hits         1226     1239      +13     
- Misses       2081     2108      +27     
- Partials      137      140       +3     

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan amsiglan merged commit 9ec5c22 into opensearch-project:main Apr 19, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-538-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ec5c22e8e22bcc090d8133e5518f80b770bf858
# Push it to GitHub
git push --set-upstream origin backport/backport-538-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-538-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-538-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ec5c22e8e22bcc090d8133e5518f80b770bf858
# Push it to GitHub
git push --set-upstream origin backport/backport-538-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-538-to-2.7.

kavilla pushed a commit to kavilla/security-analytics-dashboards-plugin that referenced this pull request Apr 19, 2023
* removed duplicate import

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Apr 19, 2023
* removed duplicate import



* updated snapshots



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Apr 19, 2023
* Correlation engine ux (#524)

* wip

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* completed rules page; added placeholder for findings flyout tabs

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverted change to show empty table

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated rule type

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated create correlation rule page

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* correlation page wip

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Correlation store and API services

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Correlation store and API services

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Correlation store and API services

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Correlation store and API services

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Correlation store and API services

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated correlations page

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated store interfaces

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed correlation store

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added api for all correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added filter support for correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* using apis; added validation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Implemented logic to populate correlations tables data.

Signed-off-by: AWSHurneyt <[email protected]>

* restricted to AND

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* log type clearable

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* code cleanup

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fixed API issue

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* code cleanup

Signed-off-by: Jovan Cvetkovic <[email protected]>

* removed redundant code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed unwanted param

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* connected refresh

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
(cherry picked from commit f565a92)

* Removed duplicate import for EuiSpacer (#538) (#540)

* removed duplicate import



* updated snapshots



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Pinned babel traverse and core (#539) (#544)

* pinned babel traverse and core



* removed cyclic dependency



* added types for vis



* refactored code



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants