Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Suppress unwanted error notification (#456) #480

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/pages/Detectors/containers/Detectors/Detectors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default class Detectors extends Component<DetectorsProps, DetectorsState>
};
});
this.setState({ detectorHits: detectors });
} else {
} else if (!res.error.includes('no such index')) {
errorNotificationToast(notifications, 'retrieve', 'detectors', res.error);
}
} catch (e) {
Expand Down
2 changes: 1 addition & 1 deletion public/pages/Overview/models/OverviewViewModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class OverviewViewModelActor {
const res = await this.services?.detectorsService.getDetectors();
if (res?.ok) {
this.overviewViewModel.detectors = res.response.hits.hits;
} else {
} else if (!res?.error.includes('no such index')) {
errorNotificationToast(this.notifications, 'retrieve', 'detectors', res.error);
}
}
Expand Down