Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty states for Overview page #467

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Mar 2, 2023

Description

This PR makes following changes to the Overview page:

  • Empty state for summary visualization and Alert/Finding stat
  • Sorted recent alerts and findings in descending order

Issues Resolved

#464

Output screenshot

image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan requested a review from a team March 2, 2023 02:14
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #467 (a7f06a9) into main (ab6a342) will decrease coverage by 0.15%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   35.36%   35.21%   -0.15%     
==========================================
  Files         116      116              
  Lines        3133     3149      +16     
  Branches      492      501       +9     
==========================================
+ Hits         1108     1109       +1     
- Misses       1905     1920      +15     
  Partials      120      120              
Impacted Files Coverage Δ
...ges/Overview/components/Widgets/TopRulesWidget.tsx 30.00% <0.00%> (-3.34%) ⬇️
...Overview/components/Widgets/RecentAlertsWidget.tsx 5.55% <0.00%> (-1.59%) ⬇️
...blic/pages/Overview/components/Widgets/Summary.tsx 2.85% <0.00%> (-0.48%) ⬇️
.../pages/Overview/components/Widgets/TableWidget.tsx 25.00% <0.00%> (ø)
...erview/components/Widgets/RecentFindingsWidget.tsx 0.00% <0.00%> (ø)
...es/Overview/components/Widgets/DetectorsWidget.tsx 5.26% <0.00%> (+5.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

amsiglan added 2 commits March 2, 2023 18:13
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan added backport 2.x backport 2.5 backport 2.6 Used for marking changes that must be merged into 2.6 branch labels Mar 7, 2023
@amsiglan amsiglan merged commit a88c791 into opensearch-project:main Mar 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2023
* added empty state UX for overview summary vis; added snapshot update command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated sort direction for overview widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated empty states for all widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored component

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a88c791)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-467-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a88c79176a33e9ee93aad718ca8d4a6f18b8f80a
# Push it to GitHub
git push --set-upstream origin backport/backport-467-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-467-to-2.5.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2023
* added empty state UX for overview summary vis; added snapshot update command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated sort direction for overview widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated empty states for all widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored component

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a88c791)
amsiglan added a commit that referenced this pull request Mar 9, 2023
* added empty state UX for overview summary vis; added snapshot update command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated sort direction for overview widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated empty states for all widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored component

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a88c791)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Mar 9, 2023
* added empty state UX for overview summary vis; added snapshot update command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated sort direction for overview widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated empty states for all widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored component

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a88c791)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…roject#476)

* added empty state UX for overview summary vis; added snapshot update command for jest test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated sort direction for overview widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated empty states for all widgets

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored component

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit a88c791)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.5 backport 2.6 Used for marking changes that must be merged into 2.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants