Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit correlation Alert Trigger fix #1180

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

riysaxen-amzn
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn commented Oct 9, 2024

Description

  • This PR fixes the issue reported recently with Correlation Alert Trigger.
    • On Edit page of correlation Alert Rule Correlation Alert Trigger configuration disappears, this PR fixes that bug.
    • Delete Correlation Alert Trigger on updating The Correlation Rule

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@riysaxen-amzn riysaxen-amzn requested a review from amsiglan October 9, 2024 23:34
@riysaxen-amzn riysaxen-amzn merged commit 8220c38 into opensearch-project:main Oct 9, 2024
6 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
* edit correlation Alert Trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* extra spacing removed

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
(cherry picked from commit 8220c38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
* edit correlation Alert Trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* extra spacing removed

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
(cherry picked from commit 8220c38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Oct 9, 2024
* edit correlation Alert Trigger fix



* delete correlation alert trigger fix



* delete correlation alert trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* extra spacing removed



---------


(cherry picked from commit 8220c38)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2024
* edit correlation Alert Trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* extra spacing removed

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
(cherry picked from commit 8220c38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2024
* edit correlation Alert Trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* delete correlation alert trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* edit correlation rule trigger fix

Signed-off-by: Riya Saxena <[email protected]>

* extra spacing removed

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
(cherry picked from commit 8220c38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Oct 10, 2024
* edit correlation Alert Trigger fix



* delete correlation alert trigger fix



* delete correlation alert trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* extra spacing removed



---------


(cherry picked from commit 8220c38)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Oct 10, 2024
* edit correlation Alert Trigger fix



* delete correlation alert trigger fix



* delete correlation alert trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* extra spacing removed



---------


(cherry picked from commit 8220c38)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Oct 10, 2024
* edit correlation Alert Trigger fix



* delete correlation alert trigger fix



* delete correlation alert trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* edit correlation rule trigger fix



* extra spacing removed



---------


(cherry picked from commit 8220c38)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants