Fix UI issues #1107
Merged
Fix UI issues #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
Signed-off-by: Amardeepsingh Siglani <[email protected]>
eirsep
approved these changes
Aug 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 31.76% 28.11% -3.65%
==========================================
Files 162 191 +29
Lines 5509 7116 +1607
Branches 1027 1364 +337
==========================================
+ Hits 1750 2001 +251
- Misses 3552 4900 +1348
- Partials 207 215 +8 ☔ View full report in Codecov by Sentry. |
AWSHurneyt
approved these changes
Aug 9, 2024
|
Tests passed:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* updated vega imports; fixed get correlated findings Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed correlation alerts filtering; improved list iocs pagination Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated help text for data source selection Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed active condition for threat intel source Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d3548eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* updated vega imports; fixed get correlated findings Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed correlation alerts filtering; improved list iocs pagination Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated help text for data source selection Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed active condition for threat intel source Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d3548eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* updated vega imports; fixed get correlated findings Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed correlation alerts filtering; improved list iocs pagination Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated help text for data source selection Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed active condition for threat intel source Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d3548eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Aug 10, 2024
amsiglan
pushed a commit
that referenced
this pull request
Aug 10, 2024
* updated vega imports; fixed get correlated findings * fixed correlation alerts filtering; improved list iocs pagination * updated help text for data source selection * fixed active condition for threat intel source --------- (cherry picked from commit d3548eb) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
added a commit
that referenced
this pull request
Aug 10, 2024
* Fix UI issues (#1107) * updated vega imports; fixed get correlated findings Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed correlation alerts filtering; improved list iocs pagination Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated help text for data source selection Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed active condition for threat intel source Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d3548eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Aug 10, 2024
* updated vega imports; fixed get correlated findings * fixed correlation alerts filtering; improved list iocs pagination * updated help text for data source selection * fixed active condition for threat intel source --------- (cherry picked from commit d3548eb) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.