[Threat intel] Fixed ui issues #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
Signed-off-by: Amardeepsingh Siglani <[email protected]>
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateDetector/components/DefineDetector/components/DetectorSchedule/Interval.tsx
Show resolved
Hide resolved
AWSHurneyt
reviewed
Jul 19, 2024
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx
Outdated
Show resolved
Hide resolved
public/pages/ThreatIntel/containers/ScanConfiguration/ThreatIntelScanConfigForm.tsx
Outdated
Show resolved
Hide resolved
|
Cypress tests passed before the operation was cancelled |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
approved these changes
Jul 19, 2024
riysaxen-amzn
approved these changes
Jul 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
* fixed ui issues Signed-off-by: Amardeepsingh Siglani <[email protected]> * update notification form; fixed edit scan Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f34835a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
* fixed ui issues Signed-off-by: Amardeepsingh Siglani <[email protected]> * update notification form; fixed edit scan Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f34835a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jul 21, 2024
* fixed ui issues * update notification form; fixed edit scan * addressed PR comments --------- (cherry picked from commit f34835a) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jul 21, 2024
* fixed ui issues * update notification form; fixed edit scan * addressed PR comments --------- (cherry picked from commit f34835a) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bunch of issues with Threat intel UI and adds validation to Add source and Scan forms.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.