-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show fields for aliases when selected in correlation rule and threat intel monitor scan #1064
Merged
amsiglan
merged 2 commits into
opensearch-project:main
from
amsiglan:show-fields-for-aliases
Jul 2, 2024
Merged
Show fields for aliases when selected in correlation rule and threat intel monitor scan #1064
amsiglan
merged 2 commits into
opensearch-project:main
from
amsiglan:show-fields-for-aliases
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
July 2, 2024 20:36
riysaxen-amzn
approved these changes
Jul 2, 2024
amsiglan
commented
Jul 2, 2024
AWSHurneyt
approved these changes
Jul 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
…intel monitor scan (#1064) * get fields for aliases in correlation rules and threat intel monitor Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0cfb24e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
…intel monitor scan (#1064) * get fields for aliases in correlation rules and threat intel monitor Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0cfb24e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jul 2, 2024
…intel monitor scan (#1064) (#1066) * get fields for aliases in correlation rules and threat intel monitor * updated snapshot --------- (cherry picked from commit 0cfb24e) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jul 2, 2024
…intel monitor scan (#1064) (#1065) * get fields for aliases in correlation rules and threat intel monitor * updated snapshot --------- (cherry picked from commit 0cfb24e) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an alias is selected in create correlation rule, it's fields don't get populated in the fields dropdown. This PR uses a different API that can fetch fields for both indices and aliases.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.