-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS][Part 3] Wired all UI components to the data source menu #1029
[MDS][Part 3] Wired all UI components to the data source menu #1029
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Overall lgtm! |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
I will be working on points 2 and 3 in the next PR where I handle the cases related to unsupported DS selection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming CI passes.
Signed-off-by: Amardeepsingh Siglani <[email protected]>
* wired all UI components to the data source menu Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed UTs Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed code for rule edit, import Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 283fdd9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#1030) * wired all UI components to the data source menu * fixed UTs * fixed code for rule edit, import * updated snapshots --------- (cherry picked from commit 283fdd9) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Building on top of changes in PRs #1003 & #1008, this PR wires all the UI pages to use the selected data source from the Data source menu when performing CRUD operations against the backend.
Detector creation and list pages:
Screen.Recording.2024-05-09.at.6.31.29.PM.mov
Rest of the pages:
Screen.Recording.2024-05-09.at.6.33.40.PM.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.