Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS][Part 3] Wired all UI components to the data source menu #1029

Merged

Conversation

amsiglan
Copy link
Collaborator

Description

Building on top of changes in PRs #1003 & #1008, this PR wires all the UI pages to use the selected data source from the Data source menu when performing CRUD operations against the backend.

Detector creation and list pages:

Screen.Recording.2024-05-09.at.6.31.29.PM.mov

Rest of the pages:

Screen.Recording.2024-05-09.at.6.33.40.PM.mov

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@riysaxen-amzn
Copy link
Collaborator

riysaxen-amzn commented May 13, 2024

Overall lgtm!
1). Let's ensure CI passes and
2). Let's also ensure if dataSource is invalid like serverless collection, it is handled properly. In that case, we can show the empty findings, alerts, detectors and correlations list.
3). I believe we are not using any other plugins API is SA, but if we are then let's make sure that integration is working as expected.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan
Copy link
Collaborator Author

Overall lgtm! 1). Let's ensure CI passes and 2). Let's also ensure if dataSource is invalid like serverless collection, it is handled properly. In that case, we can show the empty findings, alerts, detectors and correlations list. 3). I believe we are not using any other plugins API is SA, but if we are then let's make sure that integration is working as expected.

I will be working on points 2 and 3 in the next PR where I handle the cases related to unsupported DS selection

Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming CI passes.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan
Copy link
Collaborator Author

Not sure why the cypress test CI keeps getting canceled in github, all tests passed in local run
image

@amsiglan amsiglan merged commit 283fdd9 into opensearch-project:main May 16, 2024
6 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 16, 2024
* wired all UI components to the data source menu

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed UTs

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed code for rule edit, import

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 283fdd9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Jun 4, 2024
…#1030)

* wired all UI components to the data source menu



* fixed UTs



* fixed code for rule edit, import



* updated snapshots



---------


(cherry picked from commit 283fdd9)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants