Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all related docs for a finding #1006

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented May 8, 2024

Description

Currently we only show on document for a finding in the flyout since the assumption was we only trigger a finding on one doc but with the introduction of aggregation rules support, we can now have a bucket of documents in a single finding. This PR updates the Finding flyout to show all the documents.

Existing UX:
image

Proposed UX:
image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

amsiglan added 2 commits May 7, 2024 18:19
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added 3 commits May 7, 2024 23:58
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit e16e1aa into opensearch-project:main May 8, 2024
8 checks passed
@amsiglan amsiglan added backport 2.11 PRs to be backported to 2.11 branch backport 2.12 backport 2.13 Triggers backport to 2.13 branch backport 2.14 labels May 8, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-1006-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e16e1aaffe5bf207070a5d88e85daace6aca2707
# Push it to GitHub
git push --set-upstream origin backport-1006-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-1006-to-2.11.

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit e16e1aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit e16e1aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit e16e1aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding



* updated snapshots



* reverting snapshots



* updated cypress test



* updated cypress test



* refactored code



---------


(cherry picked from commit e16e1aa)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit e16e1aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding



* updated snapshots



* reverting snapshots



* updated cypress test



* updated cypress test



* refactored code



---------


(cherry picked from commit e16e1aa)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan added a commit that referenced this pull request May 8, 2024
* refactored Ux to show all documents for a finding



* updated snapshots



* reverting snapshots



* updated cypress test



* updated cypress test



* refactored code



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request May 9, 2024
* Show all related docs for a finding (#1006)

* refactored Ux to show all documents for a finding

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* reverting snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored code

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit e16e1aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* updated refs in workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan pushed a commit that referenced this pull request May 9, 2024
* refactored Ux to show all documents for a finding



* updated snapshots



* reverting snapshots



* updated cypress test



* updated cypress test



* refactored code



---------


(cherry picked from commit e16e1aa)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.11 PRs to be backported to 2.11 branch backport 2.12 backport 2.13 Triggers backport to 2.13 branch backport 2.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants