Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

Closed
jovancacvetkovic opened this issue Jan 27, 2023 · 0 comments · Fixed by #388
Closed

[BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

jovancacvetkovic opened this issue Jan 27, 2023 · 0 comments · Fixed by #388
Labels
bug Something isn't working untriaged

Comments

@jovancacvetkovic
Copy link

What is the bug?
The detector edit pages have the Security Analytics sidebar visible.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to the detectors page,
  2. Click on any detector to open the detector details page
  3. Click on any Edit button on that page
  4. Edit page opens up and there is the sidebar visible

What is the expected behavior?
There should not be a Security Analytics sidebar on any detector edit page.

Do you have any screenshots?
Currently, there is a Security Analytics sidebar visible.
there is a Security Analytics bar visible
There should not be a Security Analytics sidebar visible.
there is no Security Analytics bar visible
@jovancacvetkovic jovancacvetkovic added bug Something isn't working untriaged labels Jan 27, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 30, 2023
@jovancvetkovic3006
[BUG] The detector edit pages should not have the Security Analytics …
eb3f3a5 
…sidebar visible. opensearch-project#386

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 30, 2023
@jovancvetkovic3006
[BUG] The detector edit pages should not have the Security Analytics …
5d88553 
…sidebar visible. opensearch-project#386

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Jan 30, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue Jan 31, 2023
@jovancvetkovic3006
Hide Security Analytics sidebar for edit detector pages (#388)
c8a9410 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 31, 2023
@jovancvetkovic3006 @github-actions
Hide Security Analytics sidebar for edit detector pages (#388)
6d0e19b 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c8a9410)
amsiglan pushed a commit that referenced this issue Jan 31, 2023
@opensearch-trigger-bot @jovancvetkovic3006
Hide Security Analytics sidebar for edit detector pages (#388) (#398)
a8e85cc 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c8a9410)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Hide Security Analytics sidebar for edit detector pages (opensearch-p…
9a34029 
…roject#388) (opensearch-project#398)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. opensearch-project#386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c8a9410)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Hide Security Analytics sidebar for edit detector pages (opensearch-p…
1cea5d5 
…roject#388) (opensearch-project#398)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. opensearch-project#386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c8a9410)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this issue Mar 16, 2024
@opensearch-trigger-bot @jovancvetkovic3006 @ansjcy
Hide Security Analytics sidebar for edit detector pages (#388) (#398)
21294c1 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c8a9410)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged
Projects
None yet
Milestone
No milestone
1 participant
@jovancacvetkovic