validate fields only when group by enabled; update default window to …

…5 min (#810) Signed-off-by: Amardeepsingh Siglani <[email protected]>
opensearch-project · Nov 30, 2023 · fba42a5 · fba42a5
1 parent 059c291
commit fba42a5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/public/pages/Correlations/containers/CorrelationRuleFormModel.ts b/public/pages/Correlations/containers/CorrelationRuleFormModel.ts
@@ -7,7 +7,7 @@ import { CorrelationRuleModel } from '../../../../types';
 
 export const correlationRuleStateDefaultValue: CorrelationRuleModel = {
   name: '',
-  time_window: 60000,
+  time_window: 300000,
   queries: [
     {
       logType: '',

diff --git a/public/pages/Correlations/containers/CreateCorrelationRule.tsx b/public/pages/Correlations/containers/CreateCorrelationRule.tsx
@@ -709,15 +709,17 @@ export const CreateCorrelationRule: React.FC<CreateCorrelationRuleProps> = (
             errors.time_window = 'Invalid time window.';
           }
 
-          values.queries.forEach((query, idx) => {
-            if (!query.field) {
-              if (!errors.queries) {
-                errors.queries = Array(values.queries.length).fill(null);
-              }
+          if (groupByEnabled) {
+            values.queries.forEach((query, idx) => {
+              if (!query.field) {
+                if (!errors.queries) {
+                  errors.queries = Array(values.queries.length).fill(null);
+                }
 
-              (errors.queries as Array<{ field: string }>)[idx] = { field: 'Field is required.' };
-            }
-          });
+                (errors.queries as Array<{ field: string }>)[idx] = { field: 'Field is required.' };
+              }
+            });
+          }
 
           return errors;
         }}