updated field mappings service; abort detector creation when mapping …

…fails (#752) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1419650)
opensearch-project · Oct 25, 2023 · b6c0bbc · b6c0bbc
1 parent 09b26f0
commit b6c0bbc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/public/pages/CreateDetector/containers/CreateDetector.tsx b/public/pages/CreateDetector/containers/CreateDetector.tsx
@@ -30,6 +30,7 @@ import { NotificationsStart } from 'opensearch-dashboards/public';
 import { getPlugins } from '../../../utils/helpers';
 import { Detector, DetectorCreationStep } from '../../../../types';
 import { DataStore } from '../../../store/DataStore';
+import { errorNotificationToast } from '../../../utils/helpers';
 
 interface CreateDetectorProps extends RouteComponentProps {
   isEdit: boolean;
@@ -107,7 +108,7 @@ export default class CreateDetector extends Component<CreateDetectorProps, Creat
     this.setState({ fieldMappings });
   };
 
-  onCreateClick = () => {
+  onCreateClick = async () => {
     const { creatingDetector, detector, fieldMappings } = this.state;
     if (creatingDetector) {
       return;
@@ -121,6 +122,19 @@ export default class CreateDetector extends Component<CreateDetectorProps, Creat
       fieldMappings
     );
 
+    const fieldMappingRes = await fieldsMappingPromise;
+
+    if (!fieldMappingRes.ok) {
+      errorNotificationToast(
+        this.props.notifications,
+        'create',
+        'detector',
+        'Invalid field mappings.'
+      );
+      this.setState({ creatingDetector: false });
+      return;
+    }
+
     const createDetectorPromise = this.props.services.detectorsService.createDetector(detector);
 
     // set detector pending state, this will be used in detector details page

diff --git a/public/services/FieldMappingService.ts b/public/services/FieldMappingService.ts
@@ -43,6 +43,10 @@ export default class FieldMappingService {
       properties: {},
     };
     fieldMappings.forEach((mapping) => {
+      if (mapping.ruleFieldName === mapping.indexFieldName) {
+        return;
+      }
+
       alias_mappings.properties[mapping.ruleFieldName] = {
         type: 'alias',
         path: mapping.indexFieldName,