1.x #448
Closed
1.x #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vamsi-amazon
commented
Sep 1, 2022
vamsi-amazon
commented
- Updating 1.x branch with latest from 1.3.x (Updating 1.x branch with latest from 1.3.x #403)
- Staging for version increment automation (Staging for version increment automation #391) ([Backport 1.x] Staging for version increment automation #419)
- [1.x] Restrict chromium requests ([1.x] Restrict chromium requests #436)
- Added release notes for 1.3.5
* Fix release notes version (opensearch-project#28) Signed-off-by: Zhongnan Su <[email protected]> * Migrate Reporting Notebooks Integration (opensearch-project#21) Signed-off-by: David Cui <[email protected]> * Add Logic to Auto-populate Notebooks from Context Menu (opensearch-project#30) Signed-off-by: David Cui <[email protected]> * Change opendistro to opensearch in email template (opensearch-project#31) Signed-off-by: Joshua Li <[email protected]> * Fix case sensitive directory name for chromium zip (opensearch-project#35) Signed-off-by: David Cui <[email protected]> Co-authored-by: Carl Meadows <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Joshua Li <[email protected]> * Use output_only Parameter for notebook reports (opensearch-project#32) Signed-off-by: David Cui <[email protected]> * replace osd-version header to remove need for version number matching (opensearch-project#37) Signed-off-by: David Cui <[email protected]> * Remove visualization editor in visualization reports (opensearch-project#50) Signed-off-by: Joshua Li <[email protected]> * add condition to fix negative value display (opensearch-project#51) Signed-off-by: David Cui <[email protected]> * [Query Builder] Correctly handle match phrases when a single value is specified or when the match phrases is negated (opensearch-project#33) * [Build query] Correctly handle phrases filter that specify only one single value Contrary to the phrase filter type which always specify a meta.params.query, the phrases filter type never specify a meta.params.query even when a single value is selected. This anomaly trigger an error generated by the MonoFieldQueryBase included in the elastic-builder dependency and prevent the generation of the report. Signed-off-by: Kévin Masseix <[email protected]> * [Build query] Correctly handle negated phrases filter that specify only one single value Signed-off-by: Kévin Masseix <[email protected]> * [Build query] Correctlty handle negated phrases to exclude them from the report instead of including them Signed-off-by: Kévin Masseix <[email protected]> * Pass processing if doc[field] == null (opensearch-project#361) Pass processing if doc[field] == null Based on opendistro-for-elasticsearch/kibana-reports#327 (comment) * add test case for commit 368eb03e200b755870f1ad373e67561201ab6f31 (#370) Add missing test case for the fix "pass doc[field] == null" * Unhash page url in case store URLs in session storage is enabled from Kibana advanced setting (opensearch-project#371) * Update Namespaces/APIs/Documentation for OpenSearch (opensearch-project#55) Signed-off-by: David Cui <[email protected]> * bump path-parse version to 1.0.7 to address CVE (opensearch-project#59) Signed-off-by: David Cui <[email protected]> * increase chromium timeout to 100s (opensearch-project#58) Signed-off-by: Zhongnan Su <[email protected]> * Fix csv parsing function (opensearch-project#53) * Fix csv parsing function Signed-off-by: Joshua Li <[email protected]> * Flatten nested results for csv Signed-off-by: Joshua Li <[email protected]> * Add test case for nested fields Signed-off-by: Joshua Li <[email protected]> * Add release notes for rc1 (opensearch-project#60) Signed-off-by: David Cui <[email protected]> * configure index settings to have default 1 replica and auto-expand upperbound 2 (opensearch-project#62) Signed-off-by: Zhongnan Su <[email protected]> * Rc1 release note patch (opensearch-project#63) Signed-off-by: David Cui <[email protected]> * Bump OpenSearch Dashboards version to 1.0 (opensearch-project#64) Signed-off-by: David Cui <[email protected]> * Revert .opensearch_dashboards index references to .kibana (opensearch-project#67) Signed-off-by: David Cui <[email protected]> * Add diagrams for integration with Notifications plugin (opensearch-project#75) * add puml diagrams for integration with Notifications plugin Signed-off-by: David Cui <[email protected]> * amend Notifications plugin naming in diagram Signed-off-by: David Cui <[email protected]> * Add i18n translation support (opensearch-project#362) * PDF report is no more a screenshot, increasing the overall quality Also a issue with chrome font rendering was fixed * Add Notifications to docs (opensearch-project#87) * moved docs to root folder, update readme to include Notifications roadmap Signed-off-by: David Cui <[email protected]> * update readme to clarify current status of supported features Signed-off-by: David Cui <[email protected]> * Better support sorting for csv report based on saved search (opensearch-project#86) * Change Delivery Request Body for Notifications (opensearch-project#85) * adding opensearch changed api for report definition to save branch Signed-off-by: David Cui <[email protected]> * change delivery request body, update test cases Signed-off-by: David Cui <[email protected]> * remove console.log statement, fix DeliveryType type members to use snake case Signed-off-by: David Cui <[email protected]> * convert all snake case to camel case Signed-off-by: David Cui <[email protected]> * make configId required in schema Signed-off-by: David Cui <[email protected]> * Remove legacy notifications/delivery related code (opensearch-project#94) * remove legacy notifications/delivery related code Signed-off-by: David Cui <[email protected]> * remove commented out reference Signed-off-by: David Cui <[email protected]> * Remove dependency on demo.elastic and use local mock html for testing (opensearch-project#100) * Add code cov back (opensearch-project#98) Signed-off-by: Zhongnan Su <[email protected]> * update workflow to rename artifact in kebab case (opensearch-project#102) Signed-off-by: Zhongnan Su <[email protected]> * bump dependency version (opensearch-project#101) Signed-off-by: Zhongnan Su <[email protected]> * level up markdowns and readme (opensearch-project#97) Signed-off-by: Zhongnan Su <[email protected]> * Bump to version 1.0.0.0 (opensearch-project#103) Signed-off-by: Zhongnan Su <[email protected]> * Bump test resource(job-scheduler) to 1.0.0.0 (opensearch-project#105) Signed-off-by: Zhongnan Su <[email protected]> * fix failed cypress integ-testing (opensearch-project#106) Signed-off-by: Zhongnan Su <[email protected]> * Bump node version, fix workflow and gradle build (opensearch-project#108) * Bump nodejs version to keep up with upstream Signed-off-by: Zhongnan Su <[email protected]> * fix github workflow Signed-off-by: Zhongnan Su <[email protected]> * Add release notes for 1.0.0.0 (opensearch-project#104) Signed-off-by: Zhongnan Su <[email protected]> * Fix notebooks context menu (opensearch-project#109) Signed-off-by: Joshua Li <[email protected]> * Fix context menu download request body after schema change to add notifiaction (opensearch-project#115) Signed-off-by: Zhongnan Su <[email protected]> * Exclude time range from report details for Notebooks (opensearch-project#117) * exclude time range check for notebooks reports Signed-off-by: David Cui <[email protected]> * use report source identifier over url partial match Signed-off-by: David Cui <[email protected]> * add report details fix to release notes Signed-off-by: David Cui <[email protected]> * add more bug fixes to release notes Signed-off-by: David Cui <[email protected]> * Update regex for notebooks reports (opensearch-project#118) Signed-off-by: Joshua Li <[email protected]> * Add integtest script to the repo Signed-off-by: Peter Zhu <[email protected]> * Improve osd bootstrap on dub directory Signed-off-by: Peter Zhu <[email protected]> * Improve osd bootstrap on dub directory Signed-off-by: Peter Zhu <[email protected]> * Exclude Faulty Integration Test (opensearch-project#122) Exclude broken ITs from upstream OpenSearch * Fix cypress reporting (opensearch-project#123) * fix create test Signed-off-by: David Cui <[email protected]> * toggle video on for cypress testing (opensearch-project#124) Signed-off-by: David Cui <[email protected]> * Update Doc Links (opensearch-project#127) * update doc links in dashboards-reports Signed-off-by: David Cui <[email protected]> * Update template to reflect new branding (opensearch-project#128) Signed-off-by: kgcreative <[email protected]> * Update UI for Notifications Integration (opensearch-project#126) Update reporting front-end for Notifications integration Signed-off-by: David Cui <[email protected]> * Add themed logo to README (opensearch-project#130) Signed-off-by: Miki <[email protected]> * Fix url validation (opensearch-project#132) Signed-off-by: Joshua Li <[email protected]> * Fix url validation for context menu (opensearch-project#134) * Fix url validation for context menu Signed-off-by: Joshua Li <[email protected]> * Fix url validation Signed-off-by: Joshua Li <[email protected]> * Connect Notifications APIs to Reporting (opensearch-project#131) * call notifications APIs from reporting, saving progress Signed-off-by: David Cui <[email protected]> * enable notifications integration, update view in details pages, update tests Signed-off-by: David Cui <[email protected]> * address comments, add server APIs to call backend notifications APIs to reduce dependency Signed-off-by: David Cui <[email protected]> * add get_event API to confirm test messages are sent successfully and throw error if not Signed-off-by: David Cui <[email protected]> * add input validation for delivery subject and message, hide notifications section if opensearch notifications is not installed Signed-off-by: David Cui <[email protected]> * renamed constant for notifications to follow API_PREFIX convention Signed-off-by: David Cui <[email protected]> * rename notifications constant to reporting_notifications Signed-off-by: David Cui <[email protected]> * add list of failed channels on test message failure Signed-off-by: David Cui <[email protected]> * Fix snapshot build and upgrade to OpenSearch 1.1. (opensearch-project#140) Signed-off-by: dblock <[email protected]> * Add release notes for 1.0.1 release (opensearch-project#143) Signed-off-by: Joshua Li <[email protected]> * Bump to 1.1 in main (opensearch-project#150) * bump version to 1.1, hide delivery section Signed-off-by: David Cui <[email protected]> * Dont hide delivery by default Signed-off-by: David Cui <[email protected]> * bump version to 1.1 in dashboards reports workflow Signed-off-by: David Cui <[email protected]> * fix OSD branch to use main Signed-off-by: David Cui <[email protected]> * change from main to 1.x for dashboards version Signed-off-by: David Cui <[email protected]> * Bump opensearch ref to 1.1 in CI (opensearch-project#155) * Removed integtest.sh. (opensearch-project#157) Signed-off-by: dblock <[email protected]> * Taking RBAC settings from Alerting plugin default to false Other changes: 1. Legacy settings removed because all relavent settings are removed or taken from Alerting plugin 2. Poll API removed as it is not used [Tests] All existing tests passed Signed-off-by: @akbhatta * Bump tmpl from 1.0.4 to 1.0.5 in /dashboards-reports (opensearch-project#164) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix quoting and url-encoding (opensearch-project#153) * Replace '%2F' with '/' in relative dates Signed-off-by: Konstantin Roussou <[email protected]> * Ensure proper quoting of converted dates in URL Signed-off-by: Konstantin Roussou <[email protected]> * Use generic URL decoding Co-authored-by: Zhongnan Su <[email protected]> * Use roundUp for toDate Co-authored-by: Zhongnan Su <[email protected]> * Make date transformation same as in context_menu_helpers.js Co-authored-by: Zhongnan Su <[email protected]> * Integrate notifications backend (opensearch-project#129) * Remove hard coded localhost when calling API (opensearch-project#172) * rename plugin helper config file name to consistent with OSD (opensearch-project#180) Signed-off-by: Tengda He <[email protected]> * Add metrics for sending notifications (opensearch-project#173) * Add logic to build report detail page link and send as part of message for non-email channels (opensearch-project#182) * forward origin plus basePath to backend * Add build report link function and forward link as part of message * Update validation for observability notebooks integration (opensearch-project#174) * Build email message from template with reports links (opensearch-project#184) * remove the email tempalte and helpers from dashboards plugin * build email message from template for reporting notifcation Signed-off-by: Zhongnan Su <[email protected]> * Support range filters for csv reports (opensearch-project#185) * Forward extra headers while using headless chromium (opensearch-project#194) * Use advanced settings for date format in csv reports (opensearch-project#186) * add check in ReportInstanceActions to fix on demand report creation after report definition creation (opensearch-project#196) Signed-off by: David Cui <[email protected]> * Catch Notifications Errors on Details Pages (opensearch-project#197) * add catch statements to notifications get_configs to avoid crashing details pages Signed-off by: David Cui <[email protected]> * remove console log statment Signed-off by: David Cui <[email protected]> * remove notifications integration from details pages and update snapshots (opensearch-project#210) Signed-off-by: David Cui <[email protected]> * fix csv missing metadata fields issue and empty report on all(_source) fields (opensearch-project#206) * remove notifications references from create and edit report definition pages (opensearch-project#212) Signed-off by: David Cui <[email protected]> * refactor logic for creating DSL from saved object using buildOpensearchQuery() (opensearch-project#213) * Remove calling notifications in reports scheduler (opensearch-project#211) * Use advanced settings for csv separator and visual report timezone (opensearch-project#209) * Bump to version 1.2 (opensearch-project#203) * Bump to version 1.2 Bump OpenSearch and OpenSearch Dashboards plugins to 1.2 Related issue: opensearch-project#167 Signed-off-by: Kawika Avilla <[email protected]> * Use maven for building reports scheduler Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> * Add dco and release drafter workflows (opensearch-project#217) Signed-off-by: Joshua Li <[email protected]> * update readme notification section (opensearch-project#216) Signed-off-by: Zhongnan Su <[email protected]> * revert paths to opendistro to keep cluster permissions same with ODFE (opensearch-project#218) Signed-off-by: David Cui <[email protected]> * Create opensearch-dashboards-reports.release-notes-1.2.0.0.md Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Update the copyright notices to reflect OpenSearch Contributors (opensearch-project#220) * update the copyright notices to reflect OpenSearch Contributors Signed-off-by: David Cui <[email protected]> * add .txt to NOTICE to resolve linkchecker error Signed-off-by: David Cui <[email protected]> * changes Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * changes Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Remove notifications actions in reports scheduler (opensearch-project#221) Signed-off-by: Joshua Li <[email protected]> * add reporting osd server configurations (opensearch-project#222) Signed-off-by: Zhongnan Su <[email protected]> * Add suggested font packages in troubleshooting tips (opensearch-project#189) * add suggested font packages in troubleshooting tips Signed-off-by: David Cui <[email protected]> * add links to package documentation in README for font packages Signed-off-by: David Cui <[email protected]> * add more descriptive title under Troubleshooting Signed-off-by: David Cui <[email protected]> * add link to headless-chrome installation and add ipa-gothic-fonts link to centos 7 Signed-off-by: David Cui <[email protected]> * Update Copyright Headers (opensearch-project#226) * update copyright header for all files Signed-off-by: David Cui <[email protected]> * fix ktlint errors with extra whitespace Signed-off-by: David Cui <[email protected]> * Add support for codeowners to repo (opensearch-project#227) Signed-off-by: Ryan Bogan <[email protected]> * Fix reporting validation for observability (opensearch-project#231) * Update reporting validation for observability Signed-off-by: Joshua Li <[email protected]> * update tests Signed-off-by: Joshua Li <[email protected]> * remove poller code from frontend plugin (opensearch-project#235) Signed-off-by: Zhongnan Su <[email protected]> * bump reports-scheduler to 1.3 (opensearch-project#241) Signed-off-by: Zhongnan Su <[email protected]> * Fix apt source and link checker for CI (opensearch-project#245) * Update apt source in CI Signed-off-by: Joshua Li <[email protected]> * Try fix link checker Signed-off-by: Joshua Li <[email protected]> * Add Case Coverage tests for Create Report Definition (opensearch-project#239) * add & refactor cypress tests, add css selectors in report settings & report trigger Signed-off-by: David Cui <[email protected]> * remove comment and update jest snapshot Signed-off-by: David Cui <[email protected]> * add bwc test for reports-scheduler (opensearch-project#244) Signed-off-by: Zhongnan Su <[email protected]> * added code summary table (opensearch-project#243) * added code summary table Signed-off-by: Shenoy Pratik <[email protected]> * modularized tables, fixed links Signed-off-by: Shenoy Pratik <[email protected]> * updated header, changed bwc link Signed-off-by: Shenoy Pratik <[email protected]> * Add Cypress Case Coverage on Details Pages (opensearch-project#250) * add and refactor cypress tests for details pages Signed-off-by: David Cui <[email protected]> * update jest snapshots Signed-off-by: David Cui <[email protected]> * add utils.js file to store functions used in multiple cypress tests Signed-off-by: David Cui <[email protected]> * add gradle task to run integtest against remote cluster (opensearch-project#247) Signed-off-by: Zhongnan Su <[email protected]> * added untriaged and nolabel badges Signed-off-by: Shenoy Pratik <[email protected]> * bump dashboards-reports version to 1.3 (opensearch-project#265) Signed-off-by: Zhongnan Su <[email protected]> * add UT for request/reseponse model (opensearch-project#264) Signed-off-by: Zhongnan Su <[email protected]> * Add .whitesource configuration file * Address Reporting CVEs (opensearch-project#267) * update vulnerable package versions Signed-off-by: David Cui <[email protected]> * change ansi-regex to 5.0.1 to pass bootstrap Signed-off-by: David Cui <[email protected]> * update yarn lock for cve fixes (opensearch-project#271) Signed-off-by: David Cui <[email protected]> * add release notes for 1.2.4 Signed-off-by: David Cui <[email protected]> * remove jcenter repo from gradle build Signed-off-by: Shenoy Pratik <[email protected]> * update guava to 31.0.1-jre Signed-off-by: Shenoy Pratik <[email protected]> * WS package update (opensearch-project#283) * updated ws version Signed-off-by: Shenoy Pratik <[email protected]> * moved ws package to resolutions Signed-off-by: Shenoy Pratik <[email protected]> * updated yarn lock Signed-off-by: Shenoy Pratik <[email protected]> * add auto-backport functionality for reporting (opensearch-project#286) Add auto-backport and auto-delete workflows for reporting Signed-off-by: David Cui <[email protected]> * Change Default CI version to JDK 11 (opensearch-project#290) * change default CI version to JDK 11, add JDK versions to CI matrix and document changes in developer guide Signed-off-by: David Cui <[email protected]> * remove incorrect tag form issue template (opensearch-project#294) Signed-off-by: Zhongnan Su <[email protected]> * Fix empty or multiple date values in csv (opensearch-project#293) Signed-off-by: Zhongnan Su <[email protected]> * Update the saved object id matcher regex to match custom id (opensearch-project#295) Signed-off-by: Zhongnan Su <[email protected]> * Replace Centos links to fix link checker CI (opensearch-project#297) exclude centos links from linkchecker Signed-off-by: David Cui <[email protected]> * update regex to match custom saved object id (opensearch-project#298) Signed-off-by: Zhongnan Su <[email protected]> * Fix reporting uuid parsing (opensearch-project#300) Signed-off-by: Joshua Li <[email protected]> * Add java 8 support in compile and test (opensearch-project#304) (opensearch-project#305) * add java 8 support in compile and test Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit e753b07) Co-authored-by: Zhongnan Su <[email protected]> * Add 1.3 release notes (opensearch-project#307) (opensearch-project#308) * Add 1.3 release notes Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit 2e904c5) Co-authored-by: Zhongnan Su <[email protected]> * Bump version to 1.3.1 (opensearch-project#324) Signed-off-by: Sayali Gaikawad <[email protected]> * Bump reports dashboards to 1.3.1 (opensearch-project#331) Signed-off-by: Joshua Li <[email protected]> * Incremented version to 1.3.2. (opensearch-project#352) Signed-off-by: Zelin Hao <[email protected]> * Version bump 1.3.3 Signed-off-by: pgodithi <[email protected]> * Version bump 1.3.3 Signed-off-by: pgodithi <[email protected]> * Version bump 1.3.3 Signed-off-by: pgodithi <[email protected]> * [1.3] Bump minimist to 1.2.6 (opensearch-project#367) Signed-off-by: Joshua Li <[email protected]> * Move HTML sanitization from client to server side (opensearch-project#382) (opensearch-project#386) Move HTML sanitization to server, store markdown over HTML, remove unused imports Signed-off-by: David Cui <[email protected]> Co-authored-by: David Cui <[email protected]> * Incremented version to 1.3.4. (opensearch-project#389) * Incremented version to 1.3.4. Signed-off-by: Zelin Hao <[email protected]> * Add JS snapshot Signed-off-by: Zelin Hao <[email protected]> * Add release notes for 1.3.4.0 (opensearch-project#393) (opensearch-project#394) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 8e01eaa) Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: David Cui <[email protected]> Co-authored-by: Joshua <[email protected]> Co-authored-by: Carl Meadows <[email protected]> Co-authored-by: Kevin Masseix <[email protected]> Co-authored-by: Uzhinskiy Boris <[email protected]> Co-authored-by: David Cui <[email protected]> Co-authored-by: starcatter <[email protected]> Co-authored-by: Elias Soares <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Kevin Garcia <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: David Cui <[email protected]> Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]> Co-authored-by: Anantha Krishna Bhatta <[email protected]> Co-authored-by: Anantha Krishna Bhatta <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kroussou <[email protected]> Co-authored-by: Tengda-He <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Ryan Bogan <[email protected]> Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: pgodithi <[email protected]> Co-authored-by: Anirudha (Ani) Jadhav <[email protected]>
…ensearch-project#419) * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation: task rename updateVersion Signed-off-by: pgodithi <[email protected]> (cherry picked from commit 6667bfb) Signed-off-by: prudhvigodithi <[email protected]> Signed-off-by: pgodithi <[email protected]> Signed-off-by: prudhvigodithi <[email protected]> Co-authored-by: Prudhvi Godithi <[email protected]>
* Fix regex validation, detect iframe, embed, object tags Signed-off-by: Joshua Li <[email protected]> * Disallow redirection to non-localhost urls Signed-off-by: Joshua Li <[email protected]> * Disallow connection to non-allowlisted urls Signed-off-by: Joshua Li <[email protected]> * Disable JIT Signed-off-by: Joshua Li <[email protected]> * Fix localstorage logic Signed-off-by: Joshua Li <[email protected]> * Try to fix CI Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.