-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflow for Java 8 #303
Conversation
Signed-off-by: David Cui <[email protected]>
Signed-off-by: David Cui <[email protected]>
Signed-off-by: David Cui <[email protected]>
Did you try building and testing on 8? That would be preferred than building on 11 then testing on 11 unless it's too much work. |
When I build on 8 I get the following error on
That is referencing this line:
I can debug but wanted to get a working version posted first |
From what I'm reading here l don't see an explicit solution for this issue yet? Is the current strategy of building with 11 and testing against 8 an acceptable workaround for the time being then? |
@dblock ? |
Signed-off-by: David Cui <[email protected]>
Testing with JDK 8 against |
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
=========================================
Coverage 72.75% 72.75%
Complexity 369 369
=========================================
Files 94 94
Lines 3928 3928
Branches 609 609
=========================================
Hits 2858 2858
Misses 894 894
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Closing for #304 |
Description
Add CI workflow to test reports-scheduler with Java 8
Issues Resolved
#230
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.