Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Default CI version to JDK 11 #290

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Change Default CI version to JDK 11 #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b828d72
change default CI version to JDK 11, add JDK versions to CI matrix an…
davidcui1225 Feb 25, 2022
25c9ea6
add matrix java versions to workflow test
davidcui1225 Feb 25, 2022
9e6041c
remove java 8 and 17 from workflow
davidcui1225 Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/reports-scheduler-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@ env:

jobs:
build:
strategy:
matrix:
java: [8, 11, 14, 17]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove matrix if you are not using it in this workflow? same comment as https://github.com/opensearch-project/observability/pull/504/files#r815045939

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to make changes to correctly use the matrix versions but we need to have it as per the release campaign


runs-on: ubuntu-latest

steps:
- name: Set up JDK 1.14
- name: Set up JDK 1.11
uses: actions/setup-java@v1
with:
java-version: 1.14
java-version: 1.11

# reports-scheduler
- name: Checkout Reports Scheduler
Expand Down
13 changes: 13 additions & 0 deletions dashboards-reports/DEVELOPER_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@

So you want to contribute code to this project? Excellent! We're glad you're here. Here's what you need to do.

## Install Prerequisites

### JDK 11

OpenSearch builds using Java 11 at a minimum. This means you must have a JDK 11
installed with the environment variable `JAVA_HOME` referencing the path to Java home
for your JDK 11 installation, e.g. `JAVA_HOME=/usr/lib/jvm/jdk-11`.

By default, tests use the same runtime as `JAVA_HOME`. However, since OpenSearch
supports JDK 8, the build supports compiling with JDK 11 and testing on a different
version of JDK runtime. To do this, set `RUNTIME_JAVA_HOME` pointing to the Java home of
another JDK installation, e.g. `RUNTIME_JAVA_HOME=/usr/lib/jvm/jdk-8`.

## Setup

1. Download OpenSearch for the version that matches the [OpenSearch Dashboards version specified in package.json](./package.json#L7).
Expand Down