Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] remove jcenter repo from gradle build #278

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jan 14, 2022

Description

Build failure due to jcenter being in Reports-Scheduler. Detekt package was being used from jcenter repository. Maven Central just keeps the latest version of package as of now. Therefore, replaced jcenter with plugins.gradle to fetch the package of same version.

Issues Resolved

#276

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 requested a review from a team as a code owner January 14, 2022 00:10
@codecov-commenter
Copy link

Codecov Report

Merging #278 (3bf062e) into main (fa3fa18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #278   +/-   ##
=========================================
  Coverage     72.70%   72.70%           
  Complexity      369      369           
=========================================
  Files            94       94           
  Lines          3924     3924           
  Branches        608      608           
=========================================
  Hits           2853     2853           
  Misses          895      895           
  Partials        176      176           
Flag Coverage Δ
dashboards-reports 77.11% <ø> (ø)
reports-scheduler 68.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3fa18...3bf062e. Read the comment docs.

@ps48 ps48 merged commit 48fa2c4 into opensearch-project:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants