Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to default credentials #56

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Remove references to default credentials #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5efc9a
Remove references to default credentials
derek-ho Dec 18, 2023
e74af3e
fix path to env file
derek-ho Dec 18, 2023
7bc4b12
Add file
derek-ho Dec 18, 2023
5ee1ec7
change to strong password
derek-ho Jan 17, 2024
71393eb
test ci
joshuali925 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!
2 changes: 1 addition & 1 deletion .github/workflows/reporting-cli-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Download and run Opensearch and Dashboard
run: |
wget https://opensearch.org/samples/docker-compose.yml
docker-compose up --detach
docker-compose --env-file .github/workflows/.env up --detach

- name: Check Docker containers
run: docker ps -a
Expand Down
6 changes: 3 additions & 3 deletions DEVELOPER_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ sudo sysctl -w fs.file-max=262144
sudo sysctl -w vm.max_map_count=262144
wget https://opensearch.org/samples/docker-compose.yml
docker-compose up --detach
curl -XPOST -u 'admin:admin' 'http://localhost:5601/api/sample_data/ecommerce' -H 'osd-xsrf:true'
curl -XPOST -u 'admin:admin' 'http://localhost:5601/api/sample_data/logs' -H 'osd-xsrf:true' -H 'securitytenant: global'
curl -XPOST -u 'admin:admin' 'http://localhost:5601/api/sample_data/flights' -H 'osd-xsrf:true' -H 'securitytenant: admin_tenant'
curl -XPOST -u 'admin:< Admin password >' 'http://localhost:5601/api/sample_data/ecommerce' -H 'osd-xsrf:true'
curl -XPOST -u 'admin:< Admin password >' 'http://localhost:5601/api/sample_data/logs' -H 'osd-xsrf:true' -H 'securitytenant: global'
curl -XPOST -u 'admin:< Admin password >' 'http://localhost:5601/api/sample_data/flights' -H 'osd-xsrf:true' -H 'securitytenant: admin_tenant'
```
Run `yarn test` inside `reporting-cli`.
2 changes: 1 addition & 1 deletion USER_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ NOTE: Values from the command line argument has higher priority than environment

Sample command for downloading a dashboard report with basic authentication in png format
```
opensearch-reporting-cli --url https://localhost:5601/app/dashboards#/view/7adfa750-4c81-11e8-b3d7-01146121b73d --format png --auth basic --credentials admin:admin
opensearch-reporting-cli --url https://localhost:5601/app/dashboards#/view/7adfa750-4c81-11e8-b3d7-01146121b73d --format png --auth basic --credentials admin:< Admin password >
```
Report will be downloaded in the current directory.

Expand Down
2 changes: 1 addition & 1 deletion test/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
const path = require('path');
const exec = require('child_process').exec;
const url = "http://localhost:5601";
const credentials = "admin:admin"
const credentials = "admin:myStrongPassword123!"

function cli(args, cwd) {
return new Promise(resolve => {
Expand Down
Loading