Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional grouping ITs and refactor #89

Merged

Conversation

deshsidd
Copy link
Collaborator

@deshsidd deshsidd commented Sep 4, 2024

Description

Add additional ITs for grouping Top queries by similarity and refactor the tests.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
@deshsidd deshsidd changed the title Refactor integration tests Add additional grouping ITs and refactor Sep 4, 2024
Signed-off-by: Siddhant Deshmukh <[email protected]>
@deshsidd deshsidd merged commit 0c8f804 into opensearch-project:main Sep 4, 2024
16 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-89-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c8f804074645a8469a6ad2bcfe64da52874549e
# Push it to GitHub
git push --set-upstream origin backport/backport-89-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-89-to-2.x.

@opensearch-trigger-bot
Copy link

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.17
# Create a new branch
git switch --create backport/backport-89-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c8f804074645a8469a6ad2bcfe64da52874549e
# Push it to GitHub
git push --set-upstream origin backport/backport-89-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-89-to-2.17.

@opensearch-trigger-bot
Copy link

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.16
# Create a new branch
git switch --create backport/backport-89-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c8f804074645a8469a6ad2bcfe64da52874549e
# Push it to GitHub
git push --set-upstream origin backport/backport-89-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-89-to-2.16.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Siddhant Deshmukh <[email protected]>
(cherry picked from commit 0c8f804)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 0c8f804)

Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Siddhant Deshmukh <[email protected]>
(cherry picked from commit 0c8f804)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 0c8f804)

Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants