-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor query shape field data maps #111
Merged
jainankitk
merged 1 commit into
opensearch-project:main
from
dzane17:field-name-simplify
Sep 19, 2024
Merged
Refactor query shape field data maps #111
jainankitk
merged 1 commit into
opensearch-project:main
from
dzane17:field-name-simplify
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
requested review from
ansjcy,
jainankitk and
deshsidd
as code owners
September 9, 2024 20:23
dzane17
force-pushed
the
field-name-simplify
branch
from
September 9, 2024 20:31
20763f8
to
dc1e87a
Compare
jainankitk
reviewed
Sep 9, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
dzane17
force-pushed
the
field-name-simplify
branch
2 times, most recently
from
September 9, 2024 21:12
715e373
to
dc1e87a
Compare
deshsidd
reviewed
Sep 10, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
dzane17
force-pushed
the
field-name-simplify
branch
3 times, most recently
from
September 17, 2024 00:33
77e08c9
to
5c55429
Compare
Unrelated build failure fix: #117 |
dzane17
force-pushed
the
field-name-simplify
branch
2 times, most recently
from
September 18, 2024 17:49
030b5ef
to
00c8f18
Compare
@jainankitk @deshsidd @ansjcy Please take a look again. Since all relevant builders now implement the |
jainankitk
reviewed
Sep 19, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Zane <[email protected]>
dzane17
force-pushed
the
field-name-simplify
branch
from
September 19, 2024 23:44
00c8f18
to
8539426
Compare
jainankitk
approved these changes
Sep 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
…Name interface (#111) Signed-off-by: David Zane <[email protected]> (cherry picked from commit f1827d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
Sep 20, 2024
…Name interface (#111) (#125) (cherry picked from commit f1827d8) Signed-off-by: David Zane <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor query shape field data maps
With the introduction of
WithFieldName
interface in OpenSearch core (see opensearch-project/OpenSearch#15705), we can now simplify the field data logic in Query-Insights.Issues Resolved
Resolves #109
Related RFC #69
Testing
Large Search
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.