Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release artifacts for v0.1 of OpenSearch Migrations - Capture … #2015

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sumobrian
Copy link

…and Replay

Description

This PR is to make OpenSearch Migration tooling artifacts available on the website. The website documentation has been updated and deploy and the artifacts referenced are available.

Issue

#2003

Check List

  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@krisfreedain
Copy link
Member

@sumobrian @AMoo-Miki - I'm getting an odd error when I pull them down locally to test:

ContentIndexer: disabled. Enable with JEKYLL_ALLOW_CONTENT_INDEXER on the environment
Conflict: The following destination is shared by multiple files.
The written file may end up with unexpected contents.
/Users/freedak/Documents/OpenSearch/temp-sumobrian-opensearch-migrations-v1-project-website/_site/artifacts/opensearch/opensearch-migrations-0-1-0.html
- /Users/freedak/Documents/OpenSearch/temp-sumobrian-opensearch-migrations-v1-project-website/_artifacts/opensearch-migrations/opensearch-migrations-0.1.0-linux-arm64.markdown
- /Users/freedak/Documents/OpenSearch/temp-sumobrian-opensearch-migrations-v1-project-website/_artifacts/opensearch-migrations/opensearch-migrations-0.1.0-linux-x64.markdown
- /Users/freedak/Documents/OpenSearch/temp-sumobrian-opensearch-migrations-v1-project-website/_artifacts/opensearch-migrations/opensearch-migrations-0.1.0-macos-arm64.markdown
- /Users/freedak/Documents/OpenSearch/temp-sumobrian-opensearch-migrations-v1-project-website/_artifacts/opensearch-migrations/opensearch-migrations-0.1.0-macos-x64.markdown

                done in 94.262 seconds.

Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to Kris, i just noticed that you don't have individual artifacts for different platforms and architectures. As such:

  1. You shouldn't create multiple artifact deffinition files. please replace all of the _artifacts/opensearch-migrations/opensearch-migrations-0.1.0-*-*.markdown files with just one.
  2. In that file, use
    platform: all-platforms
    architecture: all-architectures
    
  3. Update the platforms in _layouts/versions.html with
    all-platforms: "All Platforms"
    
  4. Update the architectures in _layouts/versions.html with
    all-architectures: "All Architectures"
    

CEHENKLE
CEHENKLE previously approved these changes Sep 21, 2023
@sumobrian
Copy link
Author

Made the updates requested with slight modifications:

  1. Instead of "All Platforms" I used the verbiage "POSIX Platforms"
  2. Platform and architecture order had to be added for content to show up in div. This is an assumption made in the template.
image

Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brian for the changes; this looks great technically. We should get Charlotte to also take a look at it.

Additionally, since this PR was raised, we have had 1.3.13 and 2.10.0 releases. The changes to the _versions files should be in those versions; the PR currently modifies 1.3.12 and 2.9.0 files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants